This repository was archived by the owner on Oct 19, 2023. It is now read-only.
Change the way we check the required version of the dependency#428
Merged
Change the way we check the required version of the dependency#428
Conversation
There are still some cases for false negative where the direct constrant is ok and other indirect dependency has a problem. Although the issue is not completely fixed, this logic change allows more legitimate cases which has been failing with the previous code. It will alleviate #426
Contributor
Author
|
For a long time fix, the best way is to invoke |
chingor13
approved these changes
Mar 27, 2018
Member
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Yeah, we can do the better solution later
frost-byte
pushed a commit
to Wiser-Owl/php-docker
that referenced
this pull request
May 9, 2021
…eCloudPlatform#428) There are still some cases for false negative where the direct constrant is ok and other indirect dependency has a problem. Although the issue is not completely fixed, this logic change allows more legitimate cases which has been failing with the previous code. It will alleviate GoogleCloudPlatform#426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still some cases for false negative where the direct
constrant is ok and other indirect dependency has a problem.
Although the issue is not completely fixed, this logic change allows
more legitimate cases which has been failing with the previous code.
It will alleviate #426