This repository was archived by the owner on Oct 19, 2023. It is now read-only.
Merged
Conversation
…er has resolved dependencies
chingor13
changed the title
tmatsuo
reviewed
Apr 19, 2018
| $location = $integration->prependFileLocation(); | ||
| $fp = fopen($options['o'], 'w'); | ||
| try { | ||
| fwrite($fp, 'auto_prepend_file=' . $location . PHP_EOL); |
Contributor
There was a problem hiding this comment.
I think fwrite fails without throwing an exception. Maybe check the return value and throw?
Member
Author
There was a problem hiding this comment.
Makes sense - will add a check.
Member
Author
There was a problem hiding this comment.
Fixed - checking both fopen and fwrite
| 'o' => 'php://stdout' | ||
| ]; | ||
|
|
||
| $autoload = $options['a'] . '/vendor/autoload.php'; |
Contributor
There was a problem hiding this comment.
It will fail when you're using non-standard vendor-dir. Can we ignore this case?
Member
Author
There was a problem hiding this comment.
I think we can ignore this for now. The way it currently works will also fail with a non-standard vendor-dir because we have hard-coded fallback paths under /app/vendor/....
It looks like we can query for the vendor directory with composer config vendor-dir, but we can do this in a separate PR.
tmatsuo
approved these changes
Apr 23, 2018
frost-byte
pushed a commit
to Wiser-Owl/php-docker
that referenced
this pull request
May 9, 2021
* Defer checking stackdriver integration required versions until composer has resolved dependencies * Fix code style * Remove gen dockerfile tests * Add base tests for stackdriver integration * Run the php-base tests. Add tests for version checking google/cloud libraries * Fix phpcs * Move no_composer test to php-base * Throw and log error if we cannot open or write the php.ini config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer checking the
google/cloudlibrary versions until after composer has resolved and installed dependencies. Rather that just looking for the prepend file after composer installation, we also verifygoogle/cloudversions.Also, fixes and runs the php-base tests as part of CI.
Fixes #426