Skip to content

feat(pubsub): Add pubsub_dead_letter_remove #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quartzmo merged 2 commits into from
Nov 13, 2020
Merged

feat(pubsub): Add pubsub_dead_letter_remove #700

quartzmo merged 2 commits into from
Nov 13, 2020

Conversation

@quartzmo
Copy link
Member

@quartzmo quartzmo commented Nov 11, 2020

closes: #594

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Nov 11, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2020
@snippet-bot
Copy link

snippet-bot bot commented Nov 11, 2020 •
edited
Loading

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label.

@quartzmo quartzmo self-assigned this Nov 11, 2020
quartzmo
quartzmo commented Nov 11, 2020
View reviewed changes
pubsub/Gemfile
source "https://rubygems.org"

gem "google-cloud-pubsub"
gem "google-cloud-pubsub", "~> 2.2"
Copy link
Member Author

@quartzmo quartzmo Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRoyalTnetennba Should I not specify a version constraint for google-cloud-pubsub in the Gemfile? (For the example added in this PR, version 2.2 or above is required.)

Copy link
Contributor

@TheRoyalTnetennba TheRoyalTnetennba Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to specify version constraints where required.

@TheRoyalTnetennba TheRoyalTnetennba added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 12, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 12, 2020
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2020
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2020
@quartzmo
Copy link
Member Author

quartzmo commented Nov 13, 2020

Finally got a green build. I'm going to merge this PR now and continue to monitor test flakes with #696 and #697.

@quartzmo quartzmo merged commit 54bf6e7 into GoogleCloudPlatform:master Nov 13, 2020
@quartzmo quartzmo deleted the pubsub-remove-dead-letter-policy branch November 13, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

+1 more reviewer

@TheRoyalTnetennba TheRoyalTnetennba TheRoyalTnetennba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@quartzmo quartzmo

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pub/Sub: please add DLQ samples

4 participants

@quartzmo @TheRoyalTnetennba @anguillanneuf @kokoro-team