Build-job "tests_gaesdk" fails in webapp1 tests

[AniX]

In travis, the build-job of NOX_SESSION="tests_gaesdk" fails for the latest commit deb3444. The build-job did run successfully one year ago, see log.

The first time, the build failed with an import error, see log here, as pip 9.0.1 is used now, but it was 6.0.7 in the 2017 build. I could fix the error by upgrading the dependency of gcp-devrel-py-tools from 0.0.8 to 0.0.15 in both requirements files.

Now the build fails with two test failures in tests/gae/webapp1_test.py, see log here

• In test_new_app_old_handler_405 I would actually expect that the ALLOW header contains GET instead of being empty.

• In test_new_app_old_handler_501 I would expect 405 as status code in the response.

I'm not familiar with the history of webapp2 before 2012 or so, even less webapp 1. And I couldn't figure out the reason why the behavior changed since the build in 2017. My best guess would be a breaking change in App Engine SDK between version 1.9.54 and 1.9.66, because the same tests failed in a build for a PR request that didn't make it into master yet.

I wonder whether it is safe to drop webapp1 backward compatibility in 3.0.0 onward.

1. If webapp1 test is removed, what would be the best way to continue in master branch? Migrate the webapp1-related tests where it makes sense? Remove webapp1-exclusive code?

2. If webapp1 compatibility is kept, how should the tests be resolved? I assume there is a reason why these asserts had been added. Is there anyone here who could help with resolving the test failures?

What are your thoughts on this?

[theacodes]

I would opt for (2) if we can. What questions do you need answered to resolve the test failures?

[remko]

@theacodes I fixed the build jobs in PR #150