Replace lint-license.sh with make lint-license#1308
Merged
google-oss-prow[bot] merged 1 commit intoGoogleContainerTools:mainfrom Jul 3, 2024
Merged
Replace lint-license.sh with make lint-license#1308google-oss-prow[bot] merged 1 commit intoGoogleContainerTools:mainfrom
google-oss-prow[bot] merged 1 commit intoGoogleContainerTools:mainfrom
Conversation
karlkfi
force-pushed
the
karl-make-lint-license
branch
from
271ec56 to
eb75d9a
Compare
Merged
nan-yu
reviewed
Jul 3, 2024
Calling go-licenses from inside the makefile makes it easier to ensure that we are installing and using the vendored version every time. This also fixes an issue in Go 1.22 that was causing errors related to missing module info.
karlkfi
force-pushed
the
karl-make-lint-license
branch
from
eb75d9a to
d34a927
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nan-yu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling go-licenses from inside the makefile makes it easier to ensure that we are installing and using the vendored version every time.
This also fixes an issue in Go 1.22 that was causing errors related to missing module info.