This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Add support for Alpine (apk)#372
Closed
cmur2 wants to merge 1 commit into
Closed
Conversation
Author
|
Could I get a review from any of the codeowners @nkubala @tstromberg 🙏🏼 ? |
Author
|
Bump :) |
|
Boy would I love apline support. |
Author
|
@tequilarista sorry for the cold call but you seem to be able to merge PRs like #376 - would you mind looking at my PR? |
|
This feature is good to chainguard-images, other distroless technology builded with declarative system, apko, base on apk. @nkubala 🏓 We can use this to analyze fs under some new apk installation. |
Member
|
Yeah no reason this can't be in here. I'll see if someone with alpine experience could help review this. @imjasonh @jonjohnsonjr perhaps? |
|
Bump! This would be very handy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to add support for analyzing and diffing Alpine Docker images with
container-diff(amazing tool!).I want to contribute a differ for apk which is very similar to the Debian apt differ since the database that apk uses (located at
/lib/apk/db/installed) is also very similar to that of dpkg, with a line-based key value format.I also include tests for the new differ in this PR.
Demo of how the feature works:
I use Go 1.17 locally and did run
make test integrationand received the following output:Edit2: With Go 1.16 it works like a charm, seems to be related to introduction of https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md in Go 1.17.
Since this PR does not touch
tests/integration_test.goI assume it should be fine.Closes #361
Edit: anyone wanting to get quick access to the Linux amd64 binary can look at https://github.com/cmur2/container-diff/releases/tag/add-alpine-support at their own risk.