Allow configuring enablePlatformTags via plugins.#3710
Allow configuring enablePlatformTags via plugins.#3710tylerscoville wants to merge 4 commits intoGoogleContainerTools:masterfrom
Conversation
|
Thank you for following up on the contribution @tylerscoville! We will review this week. |
Allow configuring enablePlatformTags via plugins. Creates a new config parameter jib.to.enablePlatformTags and passes it through to the build context. comment formatting
tylerscoville
force-pushed
the
tscoville/enable_platform_tags_plugin
branch
from
4dc0a15 to
daa5a4b
Compare
|
@mpeddada1 Thanks for having a look! I pushed some changes to try and up test coverage and clean up the commit history. |
|
SonarCloud Quality Gate failed. |
| * images are not tagged with platform tags. | ||
| * @return this | ||
| */ | ||
| public Containerizer setEnablePlatformTags(boolean enablePlatformTags) { |
There was a problem hiding this comment.
Could we also add an integration test for platform tags in ContainerizerIntegrationTest? Something similar to:
There was a problem hiding this comment.
I spent a little bit of time on this and will probably need some help updating these tests. I'm not quite sure how to add another platform given the test setup?
|
@tylerscoville Thanks again! I've added a few comments. Let me know if you have any questions! |
elefeint
left a comment
elefeint
left a comment
There was a problem hiding this comment.
Minor validation question.
|
@mpeddada1 @elefeint Thank you for the review! Sorry it took me so long to get back to this. |
elefeint
left a comment
elefeint
left a comment
There was a problem hiding this comment.
Looks like adding the new method to RawConfiguration interface broke maven compilation --
Task :jib-maven-plugin:compileJava FAILED
/home/runner/work/jib/jib/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenRawConfiguration.java:30: error: MavenRawConfiguration is not abstract and does not override abstract method getEnablePlatformTags() in RawConfiguration
public class MavenRawConfiguration implements RawConfiguration {
|
@tylerscoville THANKS! I went back and looked at attempting this twice. I kept getting lost in the configuration chain. And the job kept getting me distracted with work things. I'm still trying to get some other dependencies updated so I can get to multi-arch. Do you need any help on this? |
tylerscoville
requested review from
elefeint and
mpeddada1
and removed request for
elefeint and
mpeddada1
I defaulted the RawConfiguration to return false. Hopefully this gets us past that error 🤞 |
|
@elefeint @mpeddada1 Sorry about the long delay on this. Let me know if there is anything else I can do! |
4 participants
Continuation of #3518
I'm interested in being able to configure
enablePlatformTagsvia the gradle plugin. I think this is the path to do that as described in #3523 (comment).