Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

fix: makefile container-diff on darwin#2842

Merged
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
tal66:makefile-container-diff-os
Nov 17, 2023
Merged

fix: makefile container-diff on darwin#2842
aaron-prindle merged 1 commit into
GoogleContainerTools:mainfrom
tal66:makefile-container-diff-os

Conversation

@tal66
Copy link
Copy Markdown
Contributor

@tal66 tal66 commented Nov 11, 2023

hi, this closes #2821:
make install-container-diff on darwin and linux.

Edit: i now see it was already suggested in 2145, why was it closed?

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Nov 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@JeromeJu
Copy link
Copy Markdown
Collaborator

cc @aaron-prindle might have the best context, can we check the reason for closing #2145?

@aaron-prindle
Copy link
Copy Markdown
Collaborator

aaron-prindle commented Nov 17, 2023

LGTM, thanks for the PR @tal66! #2145 was closed due to being inactive for some time (> 1 year)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multiple OS via GOOS in Makefile for deps installation for container-diff

3 participants