Verify is not working for tests that share the same container image

[katiexzhang]

Given a setup with multiple tests in a verify like:

verify:
  - name: test-1
    container:
      name: test-1
      image: 'gcr.io/cloud-builders/gcloud'
      command: ['bash']
      args:
      - '-ec'
      - |-
        echo "TESTING 1";
  - name: test-2
    container:
      name: test-2
      image: 'gcr.io/cloud-builders/gcloud'
      command: ['bash']
      args:
      - '-ec'
      - |-
        echo "TESTING 2";

skaffold verify fails with an error like:

* creating container in local docker: Error response from daemon: Conflict. The container name "/gcloud" is already in use by container "8a53722a6c1d1954b17eb92344a5f7f1e51876632a511b7ed8e865c3a4539ed7". You have to remove (or rename) that container to be able to reuse that name.

even though the two container names are different.

[katiexzhang]

Note that this kind of setup works for custom actions:

customActions:
- name: postdeploy-action
  containers:
  - name: test-1
    image: 'gcr.io/cloud-builders/gcloud'
    command: ['bash']
    args:
    - '-ec'
    - |-
      echo "TESTING 1";
  - name: test-2
    image: 'gcr.io/cloud-builders/gcloud'
    command: ['bash']
    args:
    - '-ec'
    - |-
      echo "TESTING 2";

Verify and custom actions are using different logic it seems, so for verify we should mirror what custom actions is doing.

[katiexzhang]

skaffold verify will fail the first time (where a new/newer version of the image has to get pulled).

But after the local docker cache has it, it will pass.