Skip to content

chore: re-enable TestBuildKanikoInsecureRegistry gcp test#8196

Merged
aaron-prindle merged 3 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:bug-bash-7121
Dec 8, 2022
Merged

chore: re-enable TestBuildKanikoInsecureRegistry gcp test#8196
aaron-prindle merged 3 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:bug-bash-7121

Conversation

@ericzzzzzzz
Copy link
Copy Markdown
Contributor

Fixes: #7121
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 7, 2022

Codecov Report

Merging #8196 (72d2e6d) into main (290280e) will decrease coverage by 4.35%.
The diff coverage is 53.26%.

❗ Current head 72d2e6d differs from pull request most recent head aee6590. Consider uploading reports for the commit aee6590 to get more accurate results

@@            Coverage Diff             @@
##             main    #8196      +/-   ##
==========================================
- Coverage   70.48%   66.12%   -4.36%     
==========================================
  Files         515      601      +86     
  Lines       23150    29433    +6283     
==========================================
+ Hits        16317    19463    +3146     
- Misses       5776     8509    +2733     
- Partials     1057     1461     +404     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
... and 395 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 3609771 into GoogleContainerTools:main Dec 8, 2022
ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Dec 8, 2022
aaron-prindle pushed a commit that referenced this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test Failure] TestBuildKanikoInsecureRegistry is timing our consistently

2 participants