Skip to content

Conversation

@samuelli
Copy link
Contributor

No description provided.

Copy link
Contributor

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README with slot="markers" breaking change

bower.json Outdated
"iron-selector": "PolymerElements/iron-selector#^1.5.2"
},
"devDependencies": {
"web-component-tester": "*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pin this to a specific version of wct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@samuelli
Copy link
Contributor Author

Please update README with slot="markers" breaking change

Done

@samuelli
Copy link
Contributor Author

samuelli commented May 1, 2017

Who has merging powers? @ebidel?

@e111077
Copy link
Contributor

e111077 commented May 1, 2017

oh I do apparently, but we aren't merging to master yet

@loopingz
Copy link

Nice thanks ! Could it be possible to merge to a 2.0-preview branch like other components ?
https://github.com/GoogleWebComponents/google-youtube/branches

@samuelli
Copy link
Contributor Author

I can't make a new branch. @e111077?

@e111077 e111077 changed the base branch from master to 2.0-preview May 11, 2017 18:59
@e111077
Copy link
Contributor

e111077 commented May 11, 2017

Made

@e111077 e111077 merged commit 88d323b into GoogleWebComponents:2.0-preview May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants