feat/1729 modal properties#145
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
hI, we notice something for this Warning callout modal, angular code missing an on click function |
vanessatran-ddi
force-pushed
the
chore/1729-modal-properties
branch
from
37c44a6 to
aee77da
Compare
vanessatran-ddi
changed the title
|
Issue is verified, NVDA notice is not added to documents, probably will be handle by a sperated ticket |
vanessatran-ddi
force-pushed
the
chore/1729-modal-properties
branch
2 times, most recently
from
8fc7499 to
40a1036
Compare
|
|
||
| #dynamicProp(name: string): string { | ||
| return `[${name.toLowerCase()}]="some${this.capitalize(name)}Value"`; | ||
| return `[${name.toLowerCase()}]="${this.lowerCase(name)}"`; |
There was a problem hiding this comment.
As we agree on other pull request, this will render a dynamic variable as below:
vanessatran-ddi
force-pushed
the
chore/1729-modal-properties
branch
2 times, most recently
from
7fe2567 to
6a7c3c3
Compare
|
|
||
| function isActive(id: string): boolean { | ||
| function isActive(id: string, index: number): boolean { | ||
| if (activeByScroll == null && index === 0) return true; |
There was a problem hiding this comment.
This to make sure first toc item will be highlighted if there isn't anything selected.
There was a problem hiding this comment.
Can this be moved to a separate commit?
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Mollitia obcaecati id | ||
| molestiae, natus dicta, eaque qui iusto similique, libero explicabo eligendi eius | ||
| laboriosam! Repellendus ducimus officia asperiores. Eos, eius numquam. | ||
| <p>Your progress will not be saved.</p> |
There was a problem hiding this comment.
Change the example so we have at least 1 element interactive/focusable.
vanessatran-ddi
force-pushed
the
chore/1729-modal-properties
branch
from
6a7c3c3 to
f1905ec
Compare
|
|
||
| function isActive(id: string): boolean { | ||
| function isActive(id: string, index: number): boolean { | ||
| if (activeByScroll == null && index === 0) return true; |
There was a problem hiding this comment.
Can this be moved to a separate commit?
|
|
||
| <ComponentProperties properties={componentProperties} /> | ||
| </GoATab> | ||
| <GoATab |
There was a problem hiding this comment.
Can this be moved to a separate commit?
| @@ -30,6 +30,7 @@ type CastingType = { | |||
| export default function IconButtonPage() { | |||
There was a problem hiding this comment.
Can this be moved to a separate commit?
|
|
||
| #dynamicProp(name: string): string { | ||
| return `[${name.toLowerCase()}]="some${this.capitalize(name)}Value"`; | ||
| return `[${name.toLowerCase()}]="${name}"`; |
There was a problem hiding this comment.
Are all the sandbox changes for the modal, if not they should be moved to a separate commit as well.
There was a problem hiding this comment.
Hi @chrisolsen it is supposed to change on this PR https://github.com/GovAlta/ui-components-docs/pull/148/files#diff-6cadd7933c0a461ffd36143fbe7cd935cdb5d43cffe9a7396681801382bfe722R33
vanessatran-ddi
force-pushed
the
chore/1729-modal-properties
branch
3 times, most recently
from
fdce5ca to
fc2d4d0
Compare
vanessatran-ddi
force-pushed
the
chore/1729-modal-properties
branch
from
fc2d4d0 to
6f0394d
Compare
3 participants
Description:
2 issues: 1629 and 1729
What are changed:
roleattribute to Modal component. Change the example to reflect the accessibility of the modal.arialabelattribute to Icon button sandbox, properties table and examples.openvariablelikeopenattribute.