fix(#1586): fix checkbox docs for angular reactive#149
Merged
Conversation
chrisolsen
reviewed
Apr 25, 2024
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
syedszeeshan
force-pushed
the
SZ-bug-1586
branch
from
d10072a to
923e8be
Compare
Collaborator
Author
|
-No duplicate properties The above applies to Angular Reactive section only |
chrisolsen
reviewed
Apr 25, 2024
syedszeeshan
force-pushed
the
SZ-bug-1586
branch
from
923e8be to
6f706b6
Compare
syedszeeshan
force-pushed
the
SZ-bug-1586
branch
from
6f706b6 to
f045f2a
Compare
Collaborator
Author
Hi @lizhuomeng71 , my changes in this PR are for checkbox only....not for radio group. Is this happening b/c of my changes? |
Collaborator
|
Issues is verified on Chrome, Firefox, and edge for react and angular, for mobile and desktop site |
chrisolsen
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the checkbox documentation, for the code generated for the Reactive Angular section
-Remove the duplication of [formControl] and [value] attributes
-Use [attr.disabled]="true" when disabled is selected
-Prevent disappearing of attributes when properties are changed e.g. description is provided or disabled is selected, etc.
NOTE: (@lizhuomeng71 @ArakTaiRoth @vanessatran-ddi)
KEEP goaChecked, remove goaValue...Although, the copy code will not work, but based on the discussion with @chrisolsen this is how it should be.