fix(#1897): docs microsite header feedback click handler#243
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
syedszeeshan
force-pushed
the
SZ-1897-docs
branch
2 times, most recently
from
0d9a8e3 to
9c5c601
Compare
syedszeeshan
changed the title
syedszeeshan
force-pushed
the
SZ-1897-docs
branch
from
9c5c601 to
145e582
Compare
syedszeeshan
changed the title
Collaborator
|
issue is verified on react and angular |
| tags="angular" | ||
| allowCopy={true} | ||
| code={` | ||
| import { Component } from "@angular/core"; |
Collaborator
There was a problem hiding this comment.
For other code snippets in the design system website, we don't include imports just to make things easier for users to copy the code snippet and paste to their existing code base. I suggest we should remove the import part, and refer other code snippets.
Collaborator
Author
There was a problem hiding this comment.
Thanks for pointing that out, I have removed the imports now.
syedszeeshan
force-pushed
the
SZ-1897-docs
branch
from
145e582 to
d5b6d15
Compare
syedszeeshan
force-pushed
the
SZ-1897-docs
branch
from
d5b6d15 to
110f6a7
Compare
vanessatran-ddi
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-documentation updates for MicroSiteHeader
-new example for custom click event handler for the feedback