Skip to content

Feat/2162 & 2177 document#255

Merged
ArakTaiRoth merged 2 commits into
GovAlta:alphafrom
vanessatran-ddi:feat/2162
Oct 30, 2024
Merged

Feat/2162 & 2177 document#255
ArakTaiRoth merged 2 commits into
GovAlta:alphafrom
vanessatran-ddi:feat/2162

Conversation

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 25, 2024

‼️ Deploy request for abgov-ui-component-docs rejected.

Name Link
🔨 Latest commit 87e266e

@lizhuomeng71
Copy link
Copy Markdown
Collaborator

On This page,
http://localhost:5173/components/header#tab-0
Header with menu click event
There is an extra ) in the code example
this.deviceWidth = (event as CustomEvent).detail.value);
image

@lizhuomeng71
Copy link
Copy Markdown
Collaborator

On This page,
http://localhost:5173/components/header#tab-0
Header with menu click event
fullmenubreakpoint="deviceWidth" should be [fullmenubreakpoint]="deviceWidth"
image

Comment thread src/routes/components/Accordion.tsx Outdated
@vanessatran-ddi vanessatran-ddi force-pushed the feat/2162 branch 2 times, most recently from 51f786c to 87e266e Compare October 30, 2024 16:25
@vanessatran-ddi vanessatran-ddi marked this pull request as ready for review October 30, 2024 16:27
@ArakTaiRoth ArakTaiRoth merged commit 21e16ee into GovAlta:alpha Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Header: component updates to support Privacy Portal functionality Investigate viability of component level tokens

3 participants