fix(#2397): popover close#330
Merged
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
Tested and verified it works as expected. |
vanessatran-ddi
approved these changes
Mar 31, 2025
syedszeeshan
approved these changes
Mar 31, 2025
Collaborator
|
Hi @BumbleB2na I am so sorry but I need to move it back to In Progress because it doesn't work on Firefox. It works on Chrome and Safari. |
Collaborator
Author
@vanessatran-ddi It now makes use of changing url hash to close popover |
BumbleB2na
force-pushed
the
BB-2397-popover-open
branch
3 times, most recently
from
7655972 to
9507f85
Compare
Collaborator
Author
|
Fixed another bug discovered and updated issue description |
BumbleB2na
force-pushed
the
BB-2397-popover-open
branch
from
9507f85 to
a1f821b
Compare
Collaborator
|
I tested again (2nd round) with Safari, Firefox and Chrome. All looks good now. |
syedszeeshan
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popover can be closed by
blurring parent elementchanging the url and it works in all major browsers2025-03-26-docs-popover-close.mp4