Skip to content

feat(#2278): add modal drawer doc#331

Merged
chrisolsen merged 1 commit into
alphafrom
feature/2278-modal-drawer
Apr 29, 2025
Merged

feat(#2278): add modal drawer doc#331
chrisolsen merged 1 commit into
alphafrom
feature/2278-modal-drawer

Conversation

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator

Modal drawer document.

image

Already handled the lts version page of drawer.

image

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 1, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit 3cf52fd
🔍 Latest deploy log https://app.netlify.com/sites/abgov-ui-component-docs/deploys/6810fb2d212ef90008d911bd
😎 Deploy Preview https://deploy-preview-331--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread package.json Outdated
@vanessatran-ddi vanessatran-ddi force-pushed the feature/2278-modal-drawer branch 2 times, most recently from 49dd703 to 1866ef3 Compare April 2, 2025 23:00
@vanessatran-ddi vanessatran-ddi marked this pull request as draft April 2, 2025 23:02
@vanessatran-ddi vanessatran-ddi linked an issue Apr 3, 2025 that may be closed by this pull request
@vanessatran-ddi vanessatran-ddi force-pushed the feature/2278-modal-drawer branch from 1866ef3 to 799f2df Compare April 24, 2025 21:30
@vanessatran-ddi vanessatran-ddi marked this pull request as ready for review April 24, 2025 21:31
@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

Hi @syedszeeshan and @twjeffery can you help me review this PR whenever you have time? Thank you!

@vanessatran-ddi vanessatran-ddi force-pushed the feature/2278-modal-drawer branch from 23633ce to 02d592d Compare April 25, 2025 13:44
@syedszeeshan
Copy link
Copy Markdown
Collaborator

Hi @syedszeeshan and @twjeffery can you help me review this PR whenever you have time? Thank you!

Sure I will do this ASAP.

@syedszeeshan
Copy link
Copy Markdown
Collaborator

syedszeeshan commented Apr 25, 2025

image
Tested locally, working good.

Code Review done.

Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanessatran-ddi

A couple content changes:

Badge label

  • on LTS: badge (type=important) in side menu on drawer should say "V6" in React, "V4" in Angular
image
  • on latest version: badge (type=success) in side menu on drawer should say "New"
image

Content in callout on Drawer page

  • use callout (size=medium)
  • callout heading should say: "Drawer component not available in this version"
  • callout content should say: "This component is only available in V4 of the design system components. View upgrade guide" 
(V6 for React)

image

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

Thank you @twjeffery I will work on your feedback. Also @chrisolsen noticed that the slide animation when drawer opened seems not smooth. I doubt it is because the drawer is inside the Sandbox. I will draft this PR and will move it out from the sandbox. Once I finished I will ping you and @syedszeeshan too.

@vanessatran-ddi vanessatran-ddi marked this pull request as draft April 25, 2025 23:00
@vanessatran-ddi vanessatran-ddi changed the title feat(#2278): add modal drawer doc feat(#2278): add modal drawer doc (in progress) Apr 28, 2025
@vanessatran-ddi vanessatran-ddi force-pushed the feature/2278-modal-drawer branch 2 times, most recently from d09bc25 to f403441 Compare April 28, 2025 23:23
@vanessatran-ddi vanessatran-ddi marked this pull request as ready for review April 28, 2025 23:29
@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

Hi @twjeffery I addressed the comment above. Please help me review again whenever you have time.
@syedszeeshan I rebased vs alpha, so if you have a chance to look at the code and review again.
@chrisolsen I moved the drawer out of the sandbox and the animation when we open/close the drawer is back as expected.

@vanessatran-ddi vanessatran-ddi changed the title feat(#2278): add modal drawer doc (in progress) feat(#2278): add modal drawer doc Apr 28, 2025
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanessatran-ddi

Max size property

The max size does not seem to be working when max-size > 100vw (left and right drawer) or 100vh (bottom drawer). Drawer will still overflow screen width.

Screen.Recording.2025-04-28.at.9.19.55.PM.mov

Animation on drawer close

Did we lose the animation of the drawer animating out when closing? It now just disappears when it's closed, I thought we had it animating back out the side it came in.

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

@vanessatran-ddi

Max size property

The max size does not seem to be working when max-size > 100vw (left and right drawer) or 100vh (bottom drawer). Drawer will still overflow screen width.

Screen.Recording.2025-04-28.at.9.19.55.PM.mov

Animation on drawer close

Hi @twjeffery I created an issue so we can follow up GovAlta/ui-components#2677
Unfortunately the maxsize comment can be addressed only on ui-components side.

Did we lose the animation of the drawer animating out when closing? It now just disappears when it's closed, I thought we had it animating back out the side it came in.
I created an example on stackblitz and looks like this is something I missed on ui-components side. I will create an issue for it. So sorry about that.

https://stackblitz.com/edit/vitejs-vite-cl2dvhee?file=src%2Fcomponents%2Fmodal-drawer%2FSimpleModalDrawer.tsx

@vanessatran-ddi vanessatran-ddi force-pushed the feature/2278-modal-drawer branch from f403441 to 3cf52fd Compare April 29, 2025 16:15
@chrisolsen chrisolsen merged commit 0b93223 into alpha Apr 29, 2025
7 checks passed
@chrisolsen chrisolsen deleted the feature/2278-modal-drawer branch April 29, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drawer: modal drawer variant

5 participants