feat(#2278): add modal drawer doc#331
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
49dd703 to
1866ef3
Compare
1866ef3 to
799f2df
Compare
|
Hi @syedszeeshan and @twjeffery can you help me review this PR whenever you have time? Thank you! |
23633ce to
02d592d
Compare
Sure I will do this ASAP. |
twjeffery
left a comment
There was a problem hiding this comment.
A couple content changes:
Badge label
- on LTS: badge (type=important) in side menu on drawer should say "V6" in React, "V4" in Angular
- on latest version: badge (type=success) in side menu on drawer should say "New"
Content in callout on Drawer page
- use callout (size=medium)
- callout heading should say: "Drawer component not available in this version"
- callout content should say: "This component is only available in V4 of the design system components. View upgrade guide" (V6 for React)
|
Thank you @twjeffery I will work on your feedback. Also @chrisolsen noticed that the slide animation when drawer opened seems not smooth. I doubt it is because the drawer is inside the Sandbox. I will draft this PR and will move it out from the sandbox. Once I finished I will ping you and @syedszeeshan too. |
d09bc25 to
f403441
Compare
|
Hi @twjeffery I addressed the comment above. Please help me review again whenever you have time. |
twjeffery
left a comment
There was a problem hiding this comment.
Max size property
The max size does not seem to be working when max-size > 100vw (left and right drawer) or 100vh (bottom drawer). Drawer will still overflow screen width.
Screen.Recording.2025-04-28.at.9.19.55.PM.mov
Animation on drawer close
Did we lose the animation of the drawer animating out when closing? It now just disappears when it's closed, I thought we had it animating back out the side it came in.
Hi @twjeffery I created an issue so we can follow up GovAlta/ui-components#2677 Did we lose the animation of the drawer animating out when closing? It now just disappears when it's closed, I thought we had it animating back out the side it came in. |
f403441 to
3cf52fd
Compare


Modal drawer document.
Already handled the lts version page of drawer.