feat(#1979) table with global filters examples#340
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c4a69a3 to
8983d2e
Compare
8983d2e to
6f3ce8f
Compare
There was a problem hiding this comment.
The examples look good, just a couple things to change:
- adjust the spacing between the filter input, filters, and the table - reference Figma design here
- don't disable the button, it goes against out design guidelines for accessibility reasons we avoid disabled buttons, and instead validate to guide the user when needed
Additional to consider: if this example is a best practice solution for wrapping layout when more filters are added than the parent container width
6f3ce8f to
5cab4dd
Compare
There was a problem hiding this comment.
@BumbleB2na the changes look good to me. Now that we have adjusted the example Filter data in a table, the example above it should be updated as well for layout consistency.
-
Update the Typed Chips Example example as shown here in Figma: https://www.figma.com/design/aeIJGExcpx9ecqnIVwImi1/Component-examples?node-id=95-402226&t=aP3xvoJDaX3GrL9W-4
-
change example title to: Create a chip through typing
-
make input full width
-
add input label
-
have chips stack underneath the input instead of beside, like filter example
-
horizontal and vertical gap between chips should be 8px/space-XS
5cab4dd to
c7c0b0a
Compare
twjeffery
left a comment
There was a problem hiding this comment.
@BumbleB2na All looks great! Thanks for making those changes.
One more small thing I noticed that might be worth changing while we're on it: I appreciate the error message on duplicate filter, that's a really good touch. Can we change the error message itself to be: "Enter a unique filter"? We have a lot of guidelines on content design for error messages, it's a good opportunity to show that as well through this example.
c7c0b0a to
aaab6b0
Compare
|
@vanessatran-ddi ready for review |
|
@BumbleB2na I have the following feedbacks: testing feedback:
|
@vanessatran-ddi in your stackblitz package.json update to |
aaab6b0 to
f0f4c0d
Compare
|
QA Passed. Tag @chrisolsen for his review. 😌 |



New example: Filter data in a table
2025-04-11-filter-table-example.mp4
Filters: When there are no active filters then it will show all table rows. This follows a "global filters" pattern that reduces complexity/cognitive load for users by allowing them to filter a data table on any column they want. Filters are each applied using AND conditions, filtering out table rows that do not match all filter criteria.
Updated example: Create a chip through typing
2025-04-21-typed-chip-example.mp4