feat(#2500): Added Stackblitz links to Bug Report form#342
Merged
Conversation
11 tasks
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3d118f4 to
19c55bd
Compare
twjeffery
requested changes
Apr 16, 2025
Collaborator
There was a problem hiding this comment.
Two small additional changes:
- Can you change margin bottom of both details on this page ("Why stackblitz?" and "Why jam.dev") to
xl
- That way the inputs are all appropriately spaced out, with our without a Detail. It should look like:
- Add a question mark to the detail heading "Why jam.dev".
- It should be: "Why jam.dev?" like this:
| <GoabTextarea name="replication" value={ formValues.replication } onChange={(event: GoabTextAreaOnChangeDetail) => handleChange(event.name, event.value) } rows={ 6 } width="90%" error={ !!replicationError } /> | ||
| </GoabFormItem> | ||
| <GoabFormItem label="StackBlitz URL" mb="s" helpText="Share your code with us in an isolated environment." requirement="optional" error={ stackblitzError }> | ||
| <GoabFormItem label="StackBlitz URL" mb="s" |
Collaborator
There was a problem hiding this comment.
Looking at this again, I think this would be better dropped down to a new line, and spaced out accordingly, both from the previous line and both links from each other.
Here's updated code to use, using a goa-block to bring the links to a new line and space them out:
<GoabFormItem label="StackBlitz URL" mb="s" helpText={ <>Share your code with us in an isolated environment. <GoabBlock mt={"xs"} gap={"m"}> <a href="https://stackblitz.com/~/github.com/GovAlta/ui-components-react-sandbox">React Stackblitz</a> <a href="https://stackblitz.com/~/github.com/GovAlta/ui-components-angular-sandbox">Angular Stackblitz</a> </GoabBlock> </> } requirement="optional" error={stackblitzError} >
70e43ff to
c480cf1
Compare
Collaborator
Author
@twjeffery This has been done |
chrisolsen
reviewed
Apr 22, 2025
Comment on lines
+269
to
+271
| <a href="https://stackblitz.com/~/github.com/GovAlta/ui-components-react-sandbox">React Stackblitz</a> | ||
| <a href="https://stackblitz.com/~/github.com/GovAlta/ui-components-angular-sandbox">Angular Stackblitz</a> | ||
| </GoabBlock> |
Collaborator
There was a problem hiding this comment.
I would imagine we would want these as links that load in a new tab...?
Collaborator
There was a problem hiding this comment.
yes, good point. Agreed, let's them load in a new tab
Collaborator
Author
There was a problem hiding this comment.
@chrisolsen @twjeffery This has been changed
83b3a52 to
d1ff351
Compare
chrisolsen
approved these changes
Apr 28, 2025
twjeffery
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Stackblitz links for both the Angular and React templates are now available in the help text of the Stackblitz URL Form Item.