Skip to content

feat(#2500): Added Stackblitz links to Bug Report form#342

Merged
chrisolsen merged 1 commit into
alphafrom
dustin/2500
Apr 29, 2025
Merged

feat(#2500): Added Stackblitz links to Bug Report form#342
chrisolsen merged 1 commit into
alphafrom
dustin/2500

Conversation

@ArakTaiRoth
Copy link
Copy Markdown
Collaborator

Stackblitz links for both the Angular and React templates are now available in the help text of the Stackblitz URL Form Item.

@ArakTaiRoth ArakTaiRoth linked an issue Apr 16, 2025 that may be closed by this pull request
11 tasks
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 16, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit d1ff351
🔍 Latest deploy log https://app.netlify.com/sites/abgov-ui-component-docs/deploys/680c12a9fc9bd50009d5a5c6
😎 Deploy Preview https://deploy-preview-342--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small additional changes:


  1. Can you change margin bottom of both details on this page ("Why stackblitz?" and "Why jam.dev") to xl
  • That way the inputs are all appropriately spaced out, with our without a Detail. It should look like:
image
  1. Add a question mark to the detail heading "Why jam.dev".
  • It should be: "Why jam.dev?" like this:
image

<GoabTextarea name="replication" value={ formValues.replication } onChange={(event: GoabTextAreaOnChangeDetail) => handleChange(event.name, event.value) } rows={ 6 } width="90%" error={ !!replicationError } />
</GoabFormItem>
<GoabFormItem label="StackBlitz URL" mb="s" helpText="Share your code with us in an isolated environment." requirement="optional" error={ stackblitzError }>
<GoabFormItem label="StackBlitz URL" mb="s"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this again, I think this would be better dropped down to a new line, and spaced out accordingly, both from the previous line and both links from each other.

image

Here's updated code to use, using a goa-block to bring the links to a new line and space them out:

    <GoabFormItem label="StackBlitz URL" mb="s"
                  helpText={
                    <>Share your code with us in an isolated environment.
                      <GoabBlock mt={"xs"} gap={"m"}>
                        <a
                          href="https://stackblitz.com/~/github.com/GovAlta/ui-components-react-sandbox">React
                          Stackblitz</a>
                        <a
                          href="https://stackblitz.com/~/github.com/GovAlta/ui-components-angular-sandbox">Angular
                          Stackblitz</a>
                      </GoabBlock>
                    </>
                  }
                  requirement="optional"
                  error={stackblitzError}
    >

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twjeffery This has been done

@ArakTaiRoth
Copy link
Copy Markdown
Collaborator Author

Two small additional changes:

  1. Can you change margin bottom of both details on this page ("Why stackblitz?" and "Why jam.dev") to xl
  • That way the inputs are all appropriately spaced out, with our without a Detail. It should look like:
image 2. Add a question mark to the detail heading "Why jam.dev".
  • It should be: "Why jam.dev?" like this:
image

@twjeffery This has been done

Comment thread src/routes/get-started/ReportBug.tsx Outdated
Comment on lines +269 to +271
<a href="https://stackblitz.com/~/github.com/GovAlta/ui-components-react-sandbox">React Stackblitz</a>
<a href="https://stackblitz.com/~/github.com/GovAlta/ui-components-angular-sandbox">Angular Stackblitz</a>
</GoabBlock>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine we would want these as links that load in a new tab...?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good point. Agreed, let's them load in a new tab

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisolsen @twjeffery This has been changed

@chrisolsen chrisolsen merged commit e987f31 into alpha Apr 29, 2025
7 checks passed
@ArakTaiRoth ArakTaiRoth deleted the dustin/2500 branch February 3, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include Stackblitz templates into bug reporting process

3 participants