Skip to content

fix(#2470): Updated Contribution documentation#343

Merged
chrisolsen merged 1 commit into
alphafrom
dustin/2470
Apr 28, 2025
Merged

fix(#2470): Updated Contribution documentation#343
chrisolsen merged 1 commit into
alphafrom
dustin/2470

Conversation

@ArakTaiRoth
Copy link
Copy Markdown
Collaborator

Updated the contribution documentation.

Changed the commands required to run the various playground environments. Added info about Angular wrappers and their locations. Updated testing procedures (what tests to run, who will manually test, etc...).

@ArakTaiRoth ArakTaiRoth requested a review from chrisolsen April 23, 2025 18:47
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 23, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit 6480d05
🔍 Latest deploy log https://app.netlify.com/sites/abgov-ui-component-docs/deploys/680bf7a60ef16c00089bf7b0
😎 Deploy Preview https://deploy-preview-343--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArakTaiRoth ArakTaiRoth linked an issue Apr 23, 2025 that may be closed by this pull request
3 tasks
Comment thread src/routes/get-started/Contribute.tsx Outdated
<br />
<b>Angular</b>
<CodeSnippet lang="css" allowCopy={true} code={`npm run dev:angular`}/>
<CodeSnippet lang="css" allowCopy={true} code={`npm run serve:angular`}/>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will also need to run the npm run dev:watch for both React and Angular

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line (172) npm run build can be removed.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisolsen These have been taken care of

@chrisolsen chrisolsen merged commit 4d08cbe into alpha Apr 28, 2025
7 checks passed
@chrisolsen chrisolsen deleted the dustin/2470 branch April 28, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: Changes for Contribution Process

2 participants