Skip to content

fix(#2512): rename "as" attribute as "tag" for text#346

Merged
chrisolsen merged 1 commit into
alphafrom
vanessa/goab-text-2512
Apr 29, 2025
Merged

fix(#2512): rename "as" attribute as "tag" for text#346
chrisolsen merged 1 commit into
alphafrom
vanessa/goab-text-2512

Conversation

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator

Document PR to follow up story GovAlta/ui-components#2512

@vanessatran-ddi vanessatran-ddi self-assigned this Apr 25, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 25, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit 1d430ea
🔍 Latest deploy log https://app.netlify.com/sites/abgov-ui-component-docs/deploys/680b9496b0114d0008f2b9f9
😎 Deploy Preview https://deploy-preview-346--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 38
Accessibility: 92
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/goab-text-2512 branch from 8a9e8a2 to 1d430ea Compare April 25, 2025 13:56
@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

@syedszeeshan It is ready to be tested.

@syedszeeshan
Copy link
Copy Markdown
Collaborator

syedszeeshan commented Apr 25, 2025

image
image

Tested, looks good

Code Review done.

@vanessatran-ddi vanessatran-ddi linked an issue Apr 25, 2025 that may be closed by this pull request
@chrisolsen chrisolsen requested a review from twjeffery April 28, 2025 17:36
@chrisolsen chrisolsen merged commit c92342c into alpha Apr 29, 2025
7 checks passed
@chrisolsen chrisolsen deleted the vanessa/goab-text-2512 branch April 29, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Components don't exist in Angular

4 participants