feat(#2594): document link component#348
Merged
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdfranck
force-pushed
the
benjifranck/feat-2594
branch
from
f6daab6 to
816348f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation and usage examples for the new Link component to support our alpha Angular and React components. Key changes include:
- Updating routing (versioned-router.tsx) and side menus (Components.tsx, AllComponents.tsx) to include the Link component.
- Introducing the LinkPage component with an interactive sandbox and property definitions (Link.tsx).
- Providing examples of the Link component usage (LinkExamples.tsx).
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/versioned-router.tsx | Routes now include LinkPage for the Link component. |
| src/routes/components/Link.tsx | New LinkPage documentation and sandbox implementation. |
| src/routes/components/Components.tsx | Added Link entry to the component side menu. |
| src/routes/components/AllComponents.tsx | Registers Link in the published component list. |
| src/examples/link/LinkExamples.tsx | Provides interactive examples for the Link component. |
Comments suppressed due to low confidence (1)
src/routes/components/Link.tsx:48
- The properties 'leadingIcon' and 'leadingicon' differ only in letter casing for React and Angular, which might be confusing. Consider consolidating them or clearly documenting the intent.
{ name: "leadingIcon", type: "GoAIconType", lang: "react", description: "Shows an icon to the left of the link." },
twjeffery
requested changes
Apr 30, 2025
bdfranck
force-pushed
the
benjifranck/feat-2594
branch
from
816348f to
92c6acb
Compare
Collaborator
Author
|
@twjeffery Thanks for the review! I've amended my commit with the following changes:
|
bdfranck
force-pushed
the
benjifranck/feat-2594
branch
from
92c6acb to
daaa4b9
Compare
twjeffery
approved these changes
Apr 30, 2025
Collaborator
twjeffery
left a comment
twjeffery
left a comment
There was a problem hiding this comment.
Changes look great, approved by me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the Link component which now works with our
alphaAngular and React components. (Implemented in GovAlta/ui-components#2522)