fix(#2433): make copy link & toc items to handle tab position#349
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
Author
|
Hi @syedszeeshan Can you help me test this PR? |
Collaborator
syedszeeshan
approved these changes
Apr 30, 2025
twjeffery
approved these changes
Apr 30, 2025
Collaborator
Author
|
Hello @chrisolsen I got 2 approvals and it is good to be in the final code review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What I have changed:
initialTabas 1 so when we land on the page, first tab will be highlightedBefore:

After:

Before:

(No
tabposition on the browser, so if you refresh it will come back to the first tab)After:

It has the tab position on the browser, refresh it, it will open the tab 2 and navigate to the example (refer story #2433 GovAlta/ui-components#2433)
Before:
After:
{URL}/components/accordion#tab-1#hide-and-show-many-sections-of-information-(faq)
It will return as above.