feat(#2129): add none or many checkbox example#359
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
Author
|
To do:
|
bdfranck
force-pushed
the
benjifranck/feat-2129
branch
from
ed6e139 to
87fda8f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new checkbox example that demonstrates how to select none, one, or many options, updating both the examples and their integration in the main Checkbox page.
- Updated the import for CheckboxExamples to a named export in the Checkbox page.
- Added two new example components: one for a description-based checkbox and one for a none-or-many option scenario.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/routes/components/Checkbox.tsx | Adjusted the import for CheckboxExamples and updated the GoabBadge content. |
| src/examples/checkbox/CheckboxNoneOrManyExample.tsx | Added a new example component for none-or-many checkbox selections (naming inconsistency detected). |
| src/examples/checkbox/CheckboxExamples.tsx | Rearranged and integrated the new checkbox examples. |
| src/examples/checkbox/CheckboxDescriptionExample.tsx | Introduced a component demonstrating checkboxes with descriptive help text. |
Comments suppressed due to low confidence (1)
src/examples/checkbox/CheckboxNoneOrManyExample.tsx:7
- The function name 'CheckboxDescriptionExample' does not match the file name 'CheckboxNoneOrManyExample.tsx'. Consider renaming the function to 'CheckboxNoneOrManyExample' for consistency.
export default function CheckboxDescriptionExample () {
bdfranck
force-pushed
the
benjifranck/feat-2129
branch
from
87fda8f to
587b5e3
Compare
twjeffery
approved these changes
May 6, 2025
Collaborator
twjeffery
left a comment
twjeffery
left a comment
There was a problem hiding this comment.
On the website this example looks great, works as expected.
Link to Figma works, and example matches what's in code.
Files for examples are separated to be able to referenced individually in the future on other parts of the website ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a checkbox example for selecting one, any or all items.