Skip to content

#2072 home page update#360

Merged
twjeffery merged 2 commits into
alphafrom
thomasjeffery/feat-2072
May 8, 2025
Merged

#2072 home page update#360
twjeffery merged 2 commits into
alphafrom
thomasjeffery/feat-2072

Conversation

@twjeffery
Copy link
Copy Markdown
Collaborator

@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit b7025ef
🔍 Latest deploy log https://app.netlify.com/sites/abgov-ui-component-docs/deploys/681be15509b5b200081a91a5
😎 Deploy Preview https://deploy-preview-360--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@twjeffery twjeffery marked this pull request as ready for review May 6, 2025 03:19
@twjeffery twjeffery requested a review from bdfranck May 6, 2025 03:20
@twjeffery twjeffery marked this pull request as draft May 6, 2025 15:27
@twjeffery twjeffery force-pushed the thomasjeffery/feat-2072 branch from 59bc740 to 4b0c0c2 Compare May 6, 2025 15:30
@twjeffery twjeffery marked this pull request as ready for review May 6, 2025 15:33
@bdfranck
Copy link
Copy Markdown
Collaborator

bdfranck commented May 6, 2025

When I look at the homepage...

  • ✅ I can see an "Additional resources" section
  • ✅ I can see two new containers....
    1. Common capabilities: Shared digital services
    2. User Experience best practices
  • ✅ I can see containers "stack" on mobile
image image

@bdfranck
Copy link
Copy Markdown
Collaborator

bdfranck commented May 6, 2025

  • ✅ I can see the updated "Using the design system" section
  • ✅ I can see the new "What happens when I need a new thing" section
  • ✅ I can see the sections stack on mobile
image image

@bdfranck
Copy link
Copy Markdown
Collaborator

bdfranck commented May 6, 2025

  • ✅ When I select "Go to UX practice resources", I can see the DDD UX Sharepoint.
  • ✅ When I select "Common capabilities", I can see the Common capabilities site.

Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @twjeffery! Will the below list from the mockups be implemented in a future PR?

image

@twjeffery
Copy link
Copy Markdown
Collaborator Author

twjeffery commented May 7, 2025

Looks good, @twjeffery! Will the below list from the mockups be implemented in a future PR?

image

Updates

Great catch @bdfranck, that content got lost in the updated design.

I've added that additional content to the Get started with the design system page in another commit. That way the home page is kept more high level, and we can dig into the details on the learn more link.

Updated design for get started with the design system page in Figma

image

Other changes after another review

  • I updated the styling for the card-lite component to not have to use any !important classes

@twjeffery twjeffery requested a review from bdfranck May 7, 2025 23:03
Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the preview and I see the "getting started" numbered list on the "Starting with the design system" page. Looks good to me! 👍

@twjeffery twjeffery merged commit e0f33fd into alpha May 8, 2025
7 checks passed
@twjeffery twjeffery deleted the thomasjeffery/feat-2072 branch May 8, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design system website: Add "other resources" section to website

2 participants