Skip to content

feat(#2136): add textarea example for long question#363

Merged
twjeffery merged 1 commit into
alphafrom
benjifranck/feat-2136
May 14, 2025
Merged

feat(#2136): add textarea example for long question#363
twjeffery merged 1 commit into
alphafrom
benjifranck/feat-2136

Conversation

@bdfranck
Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck commented May 8, 2025

This PR adds a textarea example for asking a question with a long response.

image

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit e36d1ac
🔍 Latest deploy log https://app.netlify.com/sites/abgov-ui-component-docs/deploys/681e29fc679a6f000823be94
😎 Deploy Preview https://deploy-preview-363--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdfranck bdfranck marked this pull request as ready for review May 8, 2025 21:06
@bdfranck bdfranck requested a review from twjeffery May 8, 2025 21:07
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example looks good! A couple small things to add/change:

  • update the number of examples from 1 to 2
image
  • build out, publish, and link to the example in the pattern library in Figma, and add the Figma link to the example heading (let me know if you have any questions)

@bdfranck bdfranck force-pushed the benjifranck/feat-2136 branch from 93ba8b5 to c464777 Compare May 9, 2025 14:52
@bdfranck bdfranck requested a review from twjeffery May 9, 2025 14:52
@bdfranck
Copy link
Copy Markdown
Collaborator Author

bdfranck commented May 9, 2025

The example looks good! A couple small things to add/change:

  • update the number of examples from 1 to 2
image * build out, publish, and link to the example in the pattern library in Figma, and add the Figma link to the example heading (let me know if you have any questions)

Good catch! I've amended my commit wit the following changes:

  • Changed the tab number from 1 to 2
  • Added the link to the Figma example

@bdfranck bdfranck force-pushed the benjifranck/feat-2136 branch from c464777 to f14c179 Compare May 9, 2025 15:01
@bdfranck
Copy link
Copy Markdown
Collaborator Author

bdfranck commented May 9, 2025

I also realized that "long-answer question" should include a hyphen. I've added one.

image

Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks for making those changes.

One more consideration:

When filling in the text area it's not a lot of working area to show 500 words, it has to scroll fairly quickly and the input stays the same height, limiting the view. It would be nice to add a grab bar on the edge of the text area to drag it taller, or even have it auto size, like this issue: GovAlta/ui-components#1568.

In the meantime for this example, maybe we should start it as 5 or 6 lines tall just so it has a bit more room?

image

@bdfranck bdfranck force-pushed the benjifranck/feat-2136 branch from f14c179 to e36d1ac Compare May 9, 2025 16:14
@bdfranck
Copy link
Copy Markdown
Collaborator Author

bdfranck commented May 9, 2025

@twjeffery Thanks! I've increased the textarea height to 6 rows. 👍

@twjeffery twjeffery merged commit f8827e9 into alpha May 14, 2025
7 checks passed
@twjeffery twjeffery deleted the benjifranck/feat-2136 branch May 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text area: Design system website contextual example

2 participants