chore: Foundations pages, content, images added to DS website#367
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
@Spark450 @ArakTaiRoth New PR created for Foundations. |
Spark450
reviewed
May 27, 2025
Collaborator
Spark450
left a comment
Spark450
left a comment
There was a problem hiding this comment.
Hi Miguel, on second thought I think we should leave all instances of "Color" alone since this is aligned to the CSS value and our design tokens. Please disregard that feedback.
| <h4>ARIA roles and headings</h4> | ||
| <p>The system uses ARIA roles to help assistive tools understand the purpose of different elements. These roles communicate what each element is for to screen readers and other assistive technologies.</p> | ||
| <ul> | ||
| <li><strong>Headings</strong> - Use structured headings (H1, H2, etc.) to organize content. H tags don't have to match the text size. For example, a Large Heading can be labeled as H1. Just keep headings consistent across pages, as this helps users find information quickly.</li> |
| </GoabGrid> | ||
|
|
||
| <GoabSpacer vSpacing="l"></GoabSpacer> | ||
| <p>Explore core icons set and their properties <Link to="/components/icons">on the component page</Link>.</p> |
Collaborator
There was a problem hiding this comment.
Explore the core icon set and its properties
| <li><strong>Links</strong> | ||
| <ul> | ||
| <li>We offer three text sizes for links based on your design needs and context.</li> | ||
| <li>Links are styled with underlined text in interactive-default blue, for better accessibility and usability.</li> |
Collaborator
There was a problem hiding this comment.
remove comma on this line
| </GoabContainer> | ||
|
|
||
| <h3 id="basic-form-template">Basic form layout example</h3> | ||
| <p>This layout is recommended for public-facing forms where the content needs to be simple, accessible, and often broken down into simple one question pages.</p> |
Collaborator
There was a problem hiding this comment.
one-question (add hyphen)
|
|
||
| <h2 id="common-layouts">Common layouts</h2> | ||
| <h3 id="basic-form-layout">Basic form layout</h3> | ||
| <p>See <Link to="/patterns/simple-form">Public form pattern</Link> for more information</p> |
Collaborator
There was a problem hiding this comment.
add "." at the end of this line.
| </GoabContainer> | ||
|
|
||
| <h3 id="side-nav-example">Side navigation layout example</h3> | ||
| <p>A 2-column layout is often used for internal applications, where there is a need for a side navigation.</p> |
Collaborator
There was a problem hiding this comment.
replace with "A 2-column layout is often used for internal applications where there is a need for side navigation."
| <GoabDivider mt="m" mb="2xl"></GoabDivider> | ||
|
|
||
| <h3 id="side-nav-side-bar">Side navigation and side bar layout</h3> | ||
| <p>A 3-column layout that has a fixed side navigation as well as a second side panel on the right hand side. The third column is often used to show tertiary information, comments, or other documents alongside the main content area. Depending on your content, for large viewports it is recommended to use a maximum content width of 1176px on the main content area.</p> |
Collaborator
There was a problem hiding this comment.
change "right hand side" to "right side"
Spark450
approved these changes
May 27, 2025
Collaborator
Spark450
left a comment
Spark450
left a comment
There was a problem hiding this comment.
Thanks for the changes! Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of Foundations section, including pages, content, images.
Also, a change to the Color tokens JSON file.