fix (#2743): version switcher stack on mobile#373
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bdfranck
reviewed
May 21, 2025
bdfranck
requested changes
May 21, 2025
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
The version switcher stacks on mobile breakpoint.
Looks good! 👍 You just need to remove the redundant media queries.
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the mobile stacking issue for the version switcher component by adding responsive media queries to adjust the layout.
- Introduces media queries for screen widths up to 623px.
- Applies flex-direction and alignment adjustments for the [slot="version"] elements.
- Currently contains duplicated media query blocks.
Collaborator
Author
|
@bdfranck this one has been fixed now |
bdfranck
approved these changes
Jun 23, 2025
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
I looked in the code again and I see a single media query.
I tested it again and see the items are side-by-side on desktop...
...and are stacked on mobile.
Looks good to me! 👍
Collaborator
|
@twjeffery This is ready to be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for this issue: GovAlta/ui-components#2743