Skip to content

feat(#2532): add radio/checkbox reveal slot example #379

Merged
twjeffery merged 1 commit into
alphafrom
vanessa/2532-radio-reveal-slot
Jun 16, 2025
Merged

feat(#2532): add radio/checkbox reveal slot example #379
twjeffery merged 1 commit into
alphafrom
vanessa/2532-radio-reveal-slot

Conversation

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator

@vanessatran-ddi vanessatran-ddi commented Jun 2, 2025

@vanessatran-ddi vanessatran-ddi self-assigned this Jun 2, 2025
@vanessatran-ddi vanessatran-ddi marked this pull request as draft June 2, 2025 17:11
@vanessatran-ddi vanessatran-ddi changed the title feat(#2532): add radio/checkbox reveal slot example feat(#2532): add radio/checkbox reveal slot example (only when https://github.com/GovAlta/ui-components/pull/2752 merged) Jun 2, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 2, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit 8bed42b
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/684c8deabc90930008e09608
😎 Deploy Preview https://deploy-preview-379--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2532-radio-reveal-slot branch from ba89f88 to ee2bd0d Compare June 9, 2025 17:10
@vanessatran-ddi vanessatran-ddi changed the title feat(#2532): add radio/checkbox reveal slot example (only when https://github.com/GovAlta/ui-components/pull/2752 merged) feat(#2532): add radio/checkbox reveal slot example Jun 9, 2025
@vanessatran-ddi vanessatran-ddi marked this pull request as ready for review June 9, 2025 17:10
@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

Hi @syedszeeshan and @twjeffery the PR is ready to be reviewed.

@syedszeeshan
Copy link
Copy Markdown
Collaborator

https://github.com/user-attachments/assets/b0cac804-578c-4ec8-b37a-a3a80dabf589
@vanessatran-ddi It is auto closing on my machine

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

Hi @syedszeeshan I fixed it. if you have time please help me review again. Thank you!

@syedszeeshan
Copy link
Copy Markdown
Collaborator

TEST PASSED

Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanessatran-ddi a small change needed to the reveal example, revealed inputs are added for the wrong checkbox option (see image below)

image

While you are doing that, please add margin-top to the callout note for the reveal so there is a bit of space between the example container and the callout note.

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2532-radio-reveal-slot branch from b87854d to 8bed42b Compare June 13, 2025 20:45
@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

@vanessatran-ddi a small change needed to the reveal example, revealed inputs are added for the wrong checkbox option (see image below)

image While you are doing that, please add margin-top to the callout note for the reveal so there is a bit of space between the example container and the callout note.

Thank you @twjeffery I pushed the change. Can you help me review again?

@twjeffery twjeffery merged commit cef3acd into alpha Jun 16, 2025
7 checks passed
@twjeffery twjeffery deleted the vanessa/2532-radio-reveal-slot branch June 16, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test ability to include conditionally reveal inputs between Radios and Checkboxes

3 participants