feat(#2687): notification banners too noisy#380
Merged
twjeffery merged 5 commits intoJun 26, 2025
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| } from "@components/version-language-switcher/VersionUpdateNotificationContext"; | ||
| import { SiteWideNotificationProvider } from "@contexts/SiteWideNotificationContext"; | ||
|
|
||
| // (Your full route definitions below this remain exactly the same...) |
Collaborator
There was a problem hiding this comment.
We can remove this comment.
vanessatran-ddi
approved these changes
Jun 4, 2025
Collaborator
vanessatran-ddi
left a comment
vanessatran-ddi
left a comment
There was a problem hiding this comment.
I have only 1 comment. The rest looks good.
Collaborator
|
This also fixed on this PR |
Collaborator
Author
|
@vanessatran-ddi I pushed an update to fix the issue above. Can you check the content section again to make sure the layout is correct? |
vanessatran-ddi
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue GovAlta/ui-components#2687:
Notification banners for LTS version and upgrading to latest version is too noisy on DS website
When a user dismisses a banner, that choice should persist across page reloads so the banner doesn’t keep reappearing. local storage or cookies?
This would reduce noise for returning users while still giving people a clear and accessible way to reopen notification banners after they have dismissed them.
View Figma Design