fix(#2722): docs update - input prop textalign#383
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
96436a8 to
658a88c
Compare
658a88c to
029378d
Compare
| @@ -733,8 +797,7 @@ export default function TextFieldPage() { | |||
| Examples | |||
| <GoabBadge type="information" content="5" /> | |||
There was a problem hiding this comment.
content should be 6 now
There was a problem hiding this comment.
PR updated, WIP.
|
|
||
| const noop = () => {}; | ||
| return ( | ||
| <Sandbox flags={["reactive"]} skipRenderOnly={"react"}> |
There was a problem hiding this comment.
PR will be updated shortly.
|
|
||
| const noop = () => {}; | ||
| return ( | ||
| <Sandbox flags={["reactive"]} skipRenderOnly={"react"}> |
There was a problem hiding this comment.
PR will be updated shortly
aa66348 to
5e3b688
Compare
twjeffery
left a comment
There was a problem hiding this comment.
Hi @syedszeeshan, a few content and formatting changes needed to the example. Should be just properties to update, let me know if you have any questions:
- Full name: align Full Name to the left and remove helper text. We would not align full name like this to the right, so it's a bit confusing. Showing a left aligned input in the field set is useful as well to show the different variations. Also, change the width of the full name input to 100%.
- Account number: change account number field to use normal input type (default). We would not add an account number as a type number for the user as it can be hard to enter in large numbers. Keep the field right aligned. Change helper text to: "This input is right aligned."
- Price: add trailing content: "per item". Set width to 7ch. Change helper text to: "The input number component is right aligned by default."
- Quantity: change helper text to: "You can set a number input to be left aligned."
- Change gap between fields to XL
a366747 to
6fc64ee
Compare
|
@twjeffery @vanessatran-ddi @ArakTaiRoth Video also updated for reference. Ready for testing. |
6fc64ee to
537e634
Compare
|
QA: Angular lts code, I run it and the price input isn't shown. (event based example) |
4b7d321 to
0132437
Compare
0132437 to
c003ddc
Compare
Since we dont have angular wrappers in LTS, I have removed the last 2 (i.e. Price and Quantity) from the examples and from the code snippet when the Angular and LTS is selected. PR will be updated shortly. |
|
@twjeffery @ArakTaiRoth However, in this case, if you want me to show a different example e.g. using |








Task: GovAlta/ui-components#2793
Story: GovAlta/ui-components#2722
Updated Video (after changes suggested by Thomas)
Task2793-For-Story-2722-Docs-Examples-Updated.mp4