Skip to content

feat(#2302): popover - add table/filter contextual example#391

Merged
ArakTaiRoth merged 13 commits into
GovAlta:alphafrom
mxsoco:mxsoco/feat-2302
Sep 25, 2025
Merged

feat(#2302): popover - add table/filter contextual example#391
ArakTaiRoth merged 13 commits into
GovAlta:alphafrom
mxsoco:mxsoco/feat-2302

Conversation

@mxsoco
Copy link
Copy Markdown
Collaborator

@mxsoco mxsoco commented Jun 27, 2025

Awaiting confirmation on Figma link

Added an informational callout:
image

Filter data in a table:
image

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 27, 2025

Deploy Preview for abgov-ui-component-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 342c7ad
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/68cc5ca0024dc50008418109
😎 Deploy Preview https://deploy-preview-391--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 35
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked in the preview deployment...

  • ✅ I can see the callout about the popover
image - ✅ I can see the table filter example image - ✅ When I select the Figma link, I can see the relevant example in Figma

Looks good to me! There's just that one minor comment about the comma to address. 👍

Comment thread src/routes/components/Popover.tsx Outdated
@mxsoco mxsoco requested a review from bdfranck July 7, 2025 21:36
Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the changes again...

  • ✅ I can see the callout on the popover page
image
  • ✅ I see the badge in the "Examples" tab has the correct number of examples.
image
  • ✅ I see the table filter example
image

Looks good to me! 👍

Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxsoco Can we extend the filter example to work with the table? (Filter the table to open and closed results when selected, and show a visual indication of the filter applied and clear action)

We did a similar filter example in code here to reference as helpful: https://design.alberta.ca/components/filter-chip#tab-1#filter-data-in-a-table

For the design and interaction, a filter chip could show up in the same way like this:

image image

Design in Figma for the above design

@mxsoco
Copy link
Copy Markdown
Collaborator Author

mxsoco commented Jul 14, 2025

@mxsoco Can we extend the filter example to work with the table? (Filter the table to open and closed results when selected, and show a visual indication of the filter applied and clear action)

We did a similar filter example in code here to reference as helpful: https://design.alberta.ca/components/filter-chip#tab-1#filter-data-in-a-table

For the design and interaction, a filter chip could show up in the same way like this:

image image
Design in Figma for the above design

@twjeffery I can try looking into it. Is there an example anywhere where filtering happens through radio buttons rather than text inputs?

@twjeffery
Copy link
Copy Markdown
Collaborator

@mxsoco Can we extend the filter example to work with the table? (Filter the table to open and closed results when selected, and show a visual indication of the filter applied and clear action)
We did a similar filter example in code here to reference as helpful: design.alberta.ca/components/filter-chip#tab-1#filter-data-in-a-table
For the design and interaction, a filter chip could show up in the same way like this:
image image
Design in Figma for the above design

@twjeffery I can try looking into it. Is there an example anywhere where filtering happens through radio buttons rather than text inputs?

We don't have on in code yet unfortunately, but that's why I was thinking that it would be useful to have. Would you be able to use the same logic in the filter example with the text input and apply it to the radio control?

Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting that together @mxsoco

Right now I see the filter working, and then you kind of get stuck there. It would be nice to also add the ability for the filter chip to clear when clicked, and for the clear button to remove the filters. Really just want to get the basics of that interaction fleshed out for a team to see.

Screen.Recording.2025-08-05.at.9.23.34.AM.mov

Also, let's add these examples to the table and filter chip component pages as well as the popover.

@ArakTaiRoth ArakTaiRoth marked this pull request as draft August 26, 2025 20:08
@mxsoco mxsoco marked this pull request as ready for review September 18, 2025 19:30
@twjeffery
Copy link
Copy Markdown
Collaborator

Thanks for making those changes @mxsoco, looks good to me now

@ArakTaiRoth ArakTaiRoth merged commit e25a2e2 into GovAlta:alpha Sep 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Popover: Design system website contextual example updates

4 participants