Skip to content

fix(#2845): checkbox lts properties#393

Merged
twjeffery merged 1 commit into
alphafrom
brendan/2845-lts-cleanup
Aug 5, 2025
Merged

fix(#2845): checkbox lts properties#393
twjeffery merged 1 commit into
alphafrom
brendan/2845-lts-cleanup

Conversation

@BumbleB2na
Copy link
Copy Markdown
Collaborator

@BumbleB2na BumbleB2na commented Jul 7, 2025

No description provided.

@BumbleB2na BumbleB2na linked an issue Jul 7, 2025 that may be closed by this pull request
Documentation for LTS and reveal slot shouldn't exist GovAlta/ui-components#2845
Closed
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 7, 2025 •
edited
Loading

✅ Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit 3ed7481
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/6888cde26d30690008e31a51
😎 Deploy Preview https://deploy-preview-393--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ArakTaiRoth ArakTaiRoth requested a review from twjeffery July 7, 2025 21:00
twjeffery
twjeffery requested changes Jul 8, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BumbleB2na The properties look to be removed, but the examples are still there on the LTS versions for both Angular and React

Acceptance Criteria:

(from issue GovAlta/ui-components#2845)

    • Remove reveal and revealarialabel properties from Angular LTS Checkbox documentation

  2. Remove Reveal example from Angular LTS Checkbox and Radio documentation

  3. Remove Reveal example from React LTS Checkbox and Radio documentation

@BumbleB2na BumbleB2na force-pushed the brendan/2845-lts-cleanup branch from c0e19e1 to c142985 Compare July 23, 2025 20:18
@BumbleB2na BumbleB2na requested a review from twjeffery July 23, 2025 20:19
@BumbleB2na BumbleB2na force-pushed the brendan/2845-lts-cleanup branch from c142985 to 9885ec0 Compare July 23, 2025 20:26
ArakTaiRoth
ArakTaiRoth reviewed Jul 28, 2025
View reviewed changes
Comment thread src/examples/checkbox/CheckboxRevealSlotExample.tsx Outdated
Comment thread src/examples/radio/RadioRevealSlotExample.tsx Outdated
@ArakTaiRoth
Copy link
Copy Markdown
Collaborator

ArakTaiRoth commented Jul 29, 2025

@BumbleB2na One thing I noticed, on the Examples page (that collects all examples). This example shows up as "Not published yet", and it shows up for both versions.

@BumbleB2na BumbleB2na force-pushed the brendan/2845-lts-cleanup branch from 9885ec0 to 3ed7481 Compare July 29, 2025 13:34
@BumbleB2na
Copy link
Copy Markdown
Collaborator Author

BumbleB2na commented Jul 29, 2025

@BumbleB2na One thing I noticed, on the Examples page (that collects all examples). This example shows up as "Not published yet", and it shows up for both versions.

Please set related github issue status to Available: GovAlta/design-system-backlog#61

@ArakTaiRoth
Copy link
Copy Markdown
Collaborator

ArakTaiRoth commented Jul 30, 2025

@twjeffery Need you to approve your requested changes and merge

@twjeffery twjeffery merged commit 9cd0abd into alpha Aug 5, 2025
7 checks passed
@twjeffery twjeffery deleted the brendan/2845-lts-cleanup branch August 5, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArakTaiRoth ArakTaiRoth ArakTaiRoth approved these changes

@twjeffery twjeffery twjeffery approved these changes

@syedszeeshan syedszeeshan Awaiting requested review from syedszeeshan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation for LTS and reveal slot shouldn't exist

3 participants

@BumbleB2na @ArakTaiRoth @twjeffery