task(#2898): move components examples#410
Merged
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
BumbleB2na
force-pushed
the
brendan/2898-move-examples
branch
from
993d0d2 to
9e3b148
Compare
ArakTaiRoth
reviewed
Jul 28, 2025
| exampleTitle="Show status in a table" | ||
| figmaExample="https://www.figma.com/design/aIRjvBzpIUH0GbkffjbL04/%E2%9D%96-Patterns-library-%7C-DDD?node-id=6304-22364&t=X0IQW5flDDaj8Vyg-4"> | ||
| </SandboxHeader> | ||
| figmaExample="https://www.figma.com/design/aIRjvBzpIUH0GbkffjbL04/%E2%9D%96-Patterns-library-%7C-DDD?node-id=6304-22364&t=X0IQW5flDDaj8Vyg-4"></SandboxHeader> |
Collaborator
There was a problem hiding this comment.
I know these lines are just automated changes, but this just seems far worse for readability. This goes for everywhere, because this was done in all files.
| import { GoabBadge, GoabBlock } from "@abgov/react-components"; | ||
| import { Sandbox } from "@components/sandbox"; | ||
|
|
||
| export const ExtractMultipleTagsTogether = () => { |
Collaborator
There was a problem hiding this comment.
Why are you using the word "Extract"? The example is literally what you have except "Show" instead of "Extract"
ArakTaiRoth
requested review from
twjeffery
and removed request for
syedszeeshan
BumbleB2na
force-pushed
the
brendan/2898-move-examples
branch
from
9e3b148 to
a030550
Compare
ArakTaiRoth
approved these changes
Jul 30, 2025
Collaborator
|
@twjeffery Needs you to review and merge |
twjeffery
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved examples for components: table, hero-banner, icon-button, badge