Skip to content

feat(#2140): microsite header - added angular and react sample code#412

Merged
bdfranck merged 5 commits into
GovAlta:alphafrom
mxsoco:mxsoco/feat-2140
Sep 11, 2025
Merged

feat(#2140): microsite header - added angular and react sample code#412
bdfranck merged 5 commits into
GovAlta:alphafrom
mxsoco:mxsoco/feat-2140

Conversation

@mxsoco
Copy link
Copy Markdown
Collaborator

@mxsoco mxsoco commented Aug 1, 2025

Added code snippets to Microsite Header examples:

image

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 1, 2025

Deploy Preview for abgov-ui-component-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6d66863
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/689e354630696d000905f909
😎 Deploy Preview https://deploy-preview-412--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the version number example, let's just use the property without the slot

version="1.2.3" instead of using a slot.

@ArakTaiRoth ArakTaiRoth requested a review from twjeffery August 11, 2025 22:12
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxsoco For some reason when we use a span in version number it's no longer visually centered. For the example, just use a string without a span for the version number

image image

@ArakTaiRoth ArakTaiRoth requested a review from twjeffery August 19, 2025 21:22
Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the code changes...

  • ✅ I see the spans have been removed from the examples

I looked at the deploy preview...

  • ✅ I see code samples are visible with the examples

Looks good to me! 👍

@twjeffery
Copy link
Copy Markdown
Collaborator

looks good, thanks!

@bdfranck bdfranck merged commit 8ae924a into GovAlta:alpha Sep 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsite header: Design system website contextual example

3 participants