fix(#2835): skeleton all section links#413
Merged
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
@BumbleB2na This fixes issue #1 in the Acceptance Criteria, but doesn't fix issue #2, "Clicking a right side navigation link shouldn't append to the hash, but change the hash", which is actually an issue sitewide. |
BumbleB2na
force-pushed
the
brendan/2835-skeleton-all-links
branch
from
e4495f5 to
eca54d0
Compare
ArakTaiRoth
approved these changes
Aug 7, 2025
ArakTaiRoth
requested review from
bdfranck and
twjeffery
and removed request for
syedszeeshan
bdfranck
approved these changes
Aug 11, 2025
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
I tested the deploy preview...
- ✅ When I'm viewing all skeleton variants, I can use the secondary nav
- ✅ The secondary nav updates to match the current view
- ✅ The secondar nav still works on other example pages
scrolling-secondary-nav.mp4
scrolling-secondary-nav-examples.mp4
We can split out the other issue into a separate ticket:
- Clicking a right side navigation link shouldn't append to the hash, but change the hash
Looks good to me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: 2835