Skip to content

fix: spacing inconsistencies across foundation and design token pages#416

Merged
bdfranck merged 1 commit into
alphafrom
thomasjeffery/content-spacing-fix
Aug 26, 2025
Merged

fix: spacing inconsistencies across foundation and design token pages#416
bdfranck merged 1 commit into
alphafrom
thomasjeffery/content-spacing-fix

Conversation

@twjeffery
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery commented Aug 11, 2025

With a recent change to the goa-text component, we have some spacing inconsistencies across foundation and design token pages.

Changes made

  • Add consistent subtitles to foundation pages (Content guidelines/Style guide)
  • Replace h1 tags with GoabText components in design token pages for uniform spacing
  • Adjust Color page title margin-bottom to improve section spacing
  • Remove excess margin-top from accessibility guidance component

Examples

Before (1)

(On every sub title before a page title)

image

After (1)

image

Before (2)

image

After (2)

image

Before (3)

image

After (3)

image

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 11, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit 3a2e2c1
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/689a6601833b70000833607e
😎 Deploy Preview https://deploy-preview-416--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 37
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@twjeffery twjeffery changed the title fix spacing inconsistencies across foundation and design token pages fix: spacing inconsistencies across foundation and design token pages Aug 11, 2025
@twjeffery twjeffery requested a review from bdfranck August 14, 2025 23:02
Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the changes...

  • ✅ I see the top margins have been removed or reduced on goaText headers where appropriate
  • ✅ I see section subheaders in the Foundations pages where appropriate
image image

Looks good to me! 👍

@bdfranck bdfranck merged commit 59d8641 into alpha Aug 26, 2025
7 checks passed
@bdfranck bdfranck deleted the thomasjeffery/content-spacing-fix branch August 26, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants