Skip to content

fix(#2801): fix Angular LTS initial tab example#419

Merged
ArakTaiRoth merged 2 commits into
alphafrom
copilot/2801-lts-initial-tab-example
Aug 20, 2025
Merged

fix(#2801): fix Angular LTS initial tab example#419
ArakTaiRoth merged 2 commits into
alphafrom
copilot/2801-lts-initial-tab-example

Conversation

@bdfranck
Copy link
Copy Markdown
Collaborator

This PR resolves GovAlta/ui-components#2801 by using a Copilot Agent with my instructions from #418. Here is Copilot's summary:

Summary of the Fix

I have successfully fixed the documentation issue reported in GitHub Issue #2801. Here's what was corrected:

Problem

The initial tab example for Angular LTS (old version) was incorrectly showing:

<goa-tabs initialTab={2}>

Solution

I corrected it to use the proper Angular syntax:

<goa-tabs initialtab="2">

Details of the Change

  1. File changed: set-a-specific-tab-to-be-active.tsx
  2. Location: Line 116 in the Angular old version code example
  3. Change: initialTab={2} → initialtab="2"

Why This Fix is Correct

According to the component properties defined in the Tabs.tsx file:

  • Angular LTS (old version): Property name is "initialtab" (lowercase) with string value in quotes
  • React (old version): Property name is "initialTab" (camelCase) with curly braces for numbers
  • Angular 18+ (new version): Uses Angular property binding syntax [initialTab]="2"

The issue specifically mentioned "Angular 3.2.2" and "Angular LTS" which corresponds to the old version in this documentation system. The fix ensures that the documentation now shows the correct syntax for Angular LTS users.

###Verification

  • The development server started successfully without errors
  • All other examples in the codebase remain unchanged and correct
  • The fix addresses exactly what was described in the GitHub issue

The documentation now correctly shows how to use the initialtab property in Angular LTS, which resolves GitHub Issue #2801.

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 14, 2025

Deploy Preview for abgov-ui-component-docs ready!

Name Link
🔨 Latest commit 6082294
🔍 Latest deploy log https://app.netlify.com/projects/abgov-ui-component-docs/deploys/68a3528526b8fb0008690144
😎 Deploy Preview https://deploy-preview-419--abgov-ui-component-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 36
Accessibility: 93
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@bdfranck bdfranck force-pushed the copilot/2801-lts-initial-tab-example branch from 8d9585c to 4034b20 Compare August 14, 2025 21:07
@bdfranck bdfranck force-pushed the copilot/2801-lts-initial-tab-example branch from 4034b20 to 1468014 Compare August 14, 2025 21:08
@bdfranck bdfranck requested a review from ArakTaiRoth August 14, 2025 21:11
@bdfranck bdfranck marked this pull request as ready for review August 14, 2025 21:29
@ArakTaiRoth
Copy link
Copy Markdown
Collaborator

@bdfranck Small issue that has nothing to do with this fix, this fix is great actually. But when I go to the example, the initialTab in the window isn't set to the second tab, it's still the first tab. This is in production now and must have been missed by me. If we can fix it in this PR, great, if not that's fine, let me know and I'll make another story for it.

@bdfranck
Copy link
Copy Markdown
Collaborator Author

@ArakTaiRoth Yeah, these one or two line changes feel much more appropriate for an agent than the slot one.

This issue sounds related to some similar tab issues. I'll take a look and make a new ticket.

@ArakTaiRoth
Copy link
Copy Markdown
Collaborator

@bdfranck Nevermind, I can't replicate on production anymore. Can you merge alpha into this PR? Potentially it was fixed in the last push to production which means it was fixed in Alpha, potentially after you made this PR

@bdfranck
Copy link
Copy Markdown
Collaborator Author

@ArakTaiRoth K, I've merged the latest alpha into this branch. 👍

@ArakTaiRoth ArakTaiRoth merged commit deaec3f into alpha Aug 20, 2025
7 checks passed
@ArakTaiRoth ArakTaiRoth deleted the copilot/2801-lts-initial-tab-example branch August 20, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong example for inititalTab

2 participants