feat(#2145): header - added contextual examples#431
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
bdfranck
requested changes
Sep 24, 2025
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
Looks good! There's just a couple small code changes.
| <a href="#">Manage account</a> | ||
| <a href="#">Request new staff account</a> | ||
| <a href="#">System admin</a> | ||
| <a href="#" className="interactive">Sign out</a> |
Collaborator
There was a problem hiding this comment.
The Angular examples should use the class property instead of className. Only React uses className.
| <a href="#">Manage account</a> | ||
| <a href="#">Request new staff account</a> | ||
| <a href="#">System admin</a> | ||
| <a href="#" className="interactive">Sign out</a> |
Collaborator
There was a problem hiding this comment.
Also change this className to class.
| [hasmenuclickhandler]="true" | ||
| (_menuClick)="handleMenuClick()" | ||
| > | ||
| <a href="#" className="interactive">Sign in</a> |
Collaborator
There was a problem hiding this comment.
Also change this className to class.
| [fullMenuBreakpoint]="1500" | ||
| (onMenuClick)="handleMenuClick()" | ||
| > | ||
| <a href="#" className="interactive">Sign in</a> |
Collaborator
There was a problem hiding this comment.
Also change this className to class.
bdfranck
approved these changes
Sep 25, 2025
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
I looked at the code snippets...
- ✅ I can see the Angular code uses
classand notclassName
Looks good to me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following examples: