Skip to content

fix(#2598): add app header menu props #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArakTaiRoth merged 1 commit into from
Sep 23, 2025
Merged

fix(#2598): add app header menu props #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 50 additions & 1 deletion src/routes/components/AppHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,29 @@ export default function AppHeaderPage() {
description: "Function invoked when the menu hamburger button (on mobile/tablet device) is clicked."
}
];

const appHeaderMenuLegacyProperties: ComponentProperty[] = [
{
name: "heading",
type: "string",
description: "Set the heading text displayed for the menu.",
required: true,
},
{
name: "leadingicon",
type: "GoAIconType",
description: "Set the leading icon for the menu item.",
lang: "angular"
},
{
name: "leadingIcon",
Comment thread
vanessatran-ddi marked this conversation as resolved.
type: "GoAIconType",
description: "Set the leading icon for the menu item.",
lang: "react"
},
...LegacyTestIdProperties,
];

const componentProperties: ComponentProperty[] = [
{
name: "url",
Expand Down Expand Up @@ -146,6 +169,21 @@ export default function AppHeaderPage() {
}
];

const appHeaderMenuProperties: ComponentProperty[] = [
{
name: "heading",
type: "string",
description: "Set the heading text displayed for the menu.",
required: true,
},
{
name: "leadingIcon",
type: "GoabIconType",
description: "Set the leading icon for the menu item.",
},
TestIdProperty,
];


function onSandboxChange(bindings: ComponentBinding[], props: Record<string, unknown>) {
setAppHeaderProps(props as CastingType);
Expand Down Expand Up @@ -174,7 +212,18 @@ export default function AppHeaderPage() {
</Sandbox>

{/*Component properties*/}
<ComponentProperties properties={componentProperties} oldProperties={oldComponentProperties} />
<ComponentProperties
heading="Properties - App Header"
properties={componentProperties}
oldProperties={oldComponentProperties}
/>

{/*App Header Menu Component properties*/}
<ComponentProperties
heading="Properties - App Header Menu"
properties={appHeaderMenuProperties}
oldProperties={appHeaderMenuLegacyProperties}
/>

</GoabTab>

Expand Down