feat(#2120): table - added and modified contextual examples#434
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
bdfranck
requested changes
Sep 23, 2025
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
Looks good! I just noticed a minor change with the colour value.
| allowCopy={true} | ||
| code={` | ||
| .goa-table-zebra-stripes > tr:nth-child(even) { | ||
| background-color: #F8F8F8; |
Collaborator
There was a problem hiding this comment.
Let's use a design token instead of a hex value here:
background-color: var(--goa-color-greyscale-50);
| @@ -0,0 +1,3 @@ | |||
| .goa-table-zebra-stripes > tr:nth-child(even) { | |||
| background-color: #F8F8F8; | |||
Collaborator
There was a problem hiding this comment.
Let's use a design token instead of a hex value here:
background-color: var(--goa-color-greyscale-50);
| @@ -1,16 +1,13 @@ | |||
| import SortDataInATable from "@examples/sort-data-in-a-table.tsx"; | |||
| import DisplayNumbersInATableSoTheyCanBeScannedEasily from "@examples/display-numbers-in-a-table-so-they-can-be-scanned-easily.tsx"; | |||
Collaborator
There was a problem hiding this comment.
I'm not seeing this example in Figma anymore so I think it's safe to remove.
bdfranck
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following example:
Modified the following examples:
-Display numbers in a table so they can be scanned easily -- In the Issue ticket, it was noted that this one should be removed. However, with the example on the Figma file, I kept it in. Please confirm if this should be kept or not.
