feat(#2609): add doc for GoabDataGrid#470
Merged
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vanessatran-ddi
force-pushed
the
vanessa/2609-data-grid-doc
branch
from
ce8bc47 to
c0f4f39
Compare
vanessatran-ddi
requested review from
ArakTaiRoth,
chrisolsen,
twjeffery and
willcodeforcoffee
Collaborator
Author
|
Hi @twjeffery whenever you have time can you review this PR to see if any examples/content I made for |
twjeffery
reviewed
Jan 19, 2026
Collaborator
twjeffery
left a comment
twjeffery
left a comment
There was a problem hiding this comment.
the data grid docs are looking great, just a couple things I see:
- the layout option in the sandbox controls doesn't seem to change the controls (I assume because it's still the same table? (and that it would make more sense if it also changed to a card view instead of a table)
- for the examples tab, can we set them all to icon position left
- right now when we tab through the table in example 1, it tabs to the cell for view, and then tabs to the view button, then tabs to the next cell for view, then tabs to the view button, and so on. (it shouldn't have a duplicate tab)
- indeterminate state is not showing on top checkbox for row select, is that something we want-to/can show there?
vanessatran-ddi
force-pushed
the
vanessa/2609-data-grid-doc
branch
from
8a80e42 to
13568ac
Compare
Collaborator
Author
|
Hello @chrisolsen and @twjeffery I addressed all comments. Can you help me review again?
|
twjeffery
reviewed
Jan 20, 2026
Collaborator
twjeffery
left a comment
twjeffery
left a comment
There was a problem hiding this comment.
- the double tab on the sandbox example is fixed, but the same double tab shows up on the 3 examples
- I meant to say change all of the examples to icon position right, not left, my mistake!
- the examples in the 2nd and 3rd examples are overlapping the sticky TOC
twjeffery
approved these changes
Jan 21, 2026
Collaborator
Author
|
Hi @chrisolsen This PR is ready for your code review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.