Skip to content

fix(#1321): deprecate goa-button submit type#2988

Merged
chrisolsen merged 1 commit into
alphafrom
Syed/1321-UI
Sep 2, 2025
Merged

fix(#1321): deprecate goa-button submit type#2988
chrisolsen merged 1 commit into
alphafrom
Syed/1321-UI

Conversation

@syedszeeshan
Copy link
Copy Markdown
Contributor

@syedszeeshan syedszeeshan commented Aug 25, 2025

Before (the change)

After (the change)

image

docs PR: GovAlta/ui-components-docs#426

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

@syedszeeshan syedszeeshan force-pushed the Syed/1321-UI branch 2 times, most recently from e77eb88 to 63dec0e Compare August 25, 2025 21:35
@syedszeeshan syedszeeshan linked an issue Aug 25, 2025 that may be closed by this pull request
@syedszeeshan syedszeeshan linked an issue Aug 25, 2025 that may be closed by this pull request
@syedszeeshan syedszeeshan marked this pull request as ready for review August 25, 2025 21:50
Comment thread libs/angular-components/src/lib/components/button/button.ts Outdated
Comment thread libs/react-components/src/lib/button/button.tsx Outdated
Comment thread libs/web-components/src/components/button/Button.spec.ts
@ArakTaiRoth ArakTaiRoth removed the request for review from vanessatran-ddi August 26, 2025 19:57
Comment thread libs/web-components/src/components/button/Button.spec.ts
Comment thread libs/angular-components/src/lib/components/button/button.ts Outdated
Comment thread libs/web-components/src/components/button/Button.svelte Outdated
Comment thread libs/web-components/src/common/utils.ts Outdated
@syedszeeshan syedszeeshan force-pushed the Syed/1321-UI branch 2 times, most recently from 6e0da7c to 9a65e02 Compare August 27, 2025 17:11
Comment thread libs/web-components/src/common/utils.ts
ArakTaiRoth
ArakTaiRoth previously approved these changes Aug 29, 2025
@syedszeeshan syedszeeshan changed the title fix(#1321): button deprecate submit type fix(#1321): deprecate goa-button submit type Sep 2, 2025
Comment thread libs/web-components/src/common/utils.ts
@chrisolsen chrisolsen merged commit 853a136 into alpha Sep 2, 2025
4 checks passed
@chrisolsen chrisolsen deleted the Syed/1321-UI branch September 2, 2025 20:50
@tzuge
Copy link
Copy Markdown
Collaborator

tzuge commented Sep 2, 2025

🎉 This PR is included in version 1.37.1-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Sep 2, 2025
@tzuge
Copy link
Copy Markdown
Collaborator

tzuge commented Sep 2, 2025

🎉 This PR is included in version 4.7.1-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Copy Markdown
Collaborator

tzuge commented Sep 2, 2025

🎉 This PR is included in version 6.7.1-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Copy Markdown
Collaborator

tzuge commented Sep 9, 2025

🎉 This PR is included in version 1.7.1-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Copy Markdown
Collaborator

tzuge commented Oct 3, 2025

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Oct 3, 2025
@tzuge
Copy link
Copy Markdown
Collaborator

tzuge commented Oct 3, 2025

🎉 This PR is included in version 1.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Copy Markdown
Collaborator

tzuge commented Oct 3, 2025

🎉 This PR is included in version 6.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Copy Markdown
Collaborator

tzuge commented Oct 3, 2025

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @alpha Released into alpha. released Released into production.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button: Deprecate "Submit" type

5 participants