Skip to content

fix(#3673): docs site bug sweep - push drawer filters, side menu, multi-sort, responsive grids#3675

Merged
chrisolsen merged 1 commit into
devfrom
tom/docs-bugs
Mar 26, 2026
Merged

fix(#3673): docs site bug sweep - push drawer filters, side menu, multi-sort, responsive grids#3675
chrisolsen merged 1 commit into
devfrom
tom/docs-bugs

Conversation

@twjeffery
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery commented Mar 24, 2026

Closes #3673

Summary

Hands-on walkthrough of the docs site to find and fix accumulated issues after recent PRs landing (config examples, preview images, app header V2, push drawer, get started pages).

Side menu

Push drawer filters (Examples, Components, Tokens)

  • Replaced overlay GoabxDrawer with GoabxPushDrawer on all three grid pages
  • Push drawer portaled outside the content card at the layout level so it pushes the card over
  • Negative margins on the portal cancel layout padding, letting the drawer's built-in offset handle spacing
  • --card-padding-h CSS variable keeps sticky toolbar width in sync across breakpoints
  • Filter button toggles drawer open/closed
  • At <1024px the push drawer falls back to modal overlay with proper z-index handling
  • Mobile header z-index drops when drawer is open using :has([open])

Responsive grids

  • Card grids changed from fixed repeat(4, 1fr) to auto-fill with minmax(200px, 1fr)
  • Service pattern cards use auto-fit with minmax(250px, 1fr)
  • Tokens toolbar stacking uses @container query instead of @media

Multi-sort tables

Homepage

  • "Public form" links to /examples/public-form instead of /examples?userType=citizen
  • "Workspace" links to /examples/workspace instead of /examples?userType=worker

Sticky toolbar

  • ::before constrained to content card padding (was left/right: -9999px)
  • Removed extra bottom margin when sticky
  • View toggle wrapper clipped to 40px

Mobile header

  • Title: body-s with greyscale-700 (was mobile-heading-xs)
  • Gap adjustments between menu button, logo, and title
  • Removed negative margins on icon buttons (16px from screen edge)

Other

  • Support page button changed to compact
  • Component card thumbnail margin reduced from space-xs to space-2xs

Test plan

  • Side menu: chevrons visible on category groups, all sub-menu items clickable
  • Push drawer: opens/closes on filter button, pushes content card, grid reflows
  • Push drawer <1024px: falls back to modal overlay, scrim covers mobile header
  • Push drawer mobile: modal drawer works, layout not broken
  • Multi-sort: click two columns, both show sort arrows with 1/2 badges
  • Homepage: service pattern cards link to correct pages
  • Sticky toolbar: constrained to content card width at all breakpoints
  • Mobile header: correct typography, spacing, icon button padding

@twjeffery twjeffery requested a review from Spark450 March 24, 2026 22:13
Comment thread docs/src/components/ExamplesGrid.tsx
Comment thread docs/src/pages/examples/index.astro
@Spark450 Spark450 requested a review from chrisolsen March 25, 2026 15:28
@bdfranck bdfranck self-requested a review March 25, 2026 15:54
@twjeffery twjeffery force-pushed the tom/docs-bugs branch 3 times, most recently from e5df59c to 34002ae Compare March 25, 2026 21:57
…ti-sort, responsive grids

Side menu:
- Remove stale useGroupShadowDomFixes workaround (chevrons hidden after #3595)
- Fix Foundations sub-menu navigation (missing onNavigate handler)

Push drawer filters (Examples, Components, Tokens pages):
- Replace overlay drawer with push drawer portaled outside content card
- Responsive auto-fill grids that reflow when drawer opens
- Filter button toggles drawer, modal fallback <1024px with z-index handling
- Mobile header z-index drops when drawer open via :has([open])
- Layout padding and --card-padding-h variable for sticky toolbar sync

Multi-sort tables:
- Enable sort-mode="multi" and _multisort events on all tables
- Add sort-order prop for visual 1/2 badges
- Remove redundant sort chips, keep filter/search chips only

Responsive container-aware layout:
- Container queries for toolbar stacking and view switching
- useContainerNarrow hook (ResizeObserver) replaces viewport-based useMobile
- Tables auto-switch to cards when container narrows, user can override
- Horizontal scroll on tables with edge shadows and card-edge bleed
- Mobile icon-only filter button with search + filter on one row
- Table column width constraints (name, value)

Homepage and misc:
- Service pattern links go to /examples/public-form and /examples/workspace
- Responsive pattern card grid with auto-fit
- Support page button compact, component card thumbnail margin fix
- Sticky toolbar constrained to content card width
- Mobile header: body-s typography, adjusted spacing and icon padding
- Fix description ellipsis truncation (was checking full body length)
- Table 1px border overflow workaround (calc 100% - 2px)
Copy link
Copy Markdown
Collaborator

@Spark450 Spark450 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made as discussed

@chrisolsen chrisolsen merged commit 8ca4a49 into dev Mar 26, 2026
4 checks passed
@chrisolsen chrisolsen deleted the tom/docs-bugs branch March 26, 2026 20:20
@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.41.0-dev.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.11.0-dev.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.0-dev.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.0.0-dev.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen chrisolsen added the released Released into production. label Mar 31, 2026
@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs site bugs: side menu, filter drawers, multi-sort, responsive grids, mobile header

3 participants