fix(#3882): use neutral border token on filled-accent interactive content#3881
Merged
Merged
Conversation
|
Preview removedAll preview folders cleaned from gh-pages branch. |
…tent Follow-up to #3848. That PR wired the .goa-container--interactive.accent--filled .content rule to use --goa-container-interactive-border, which resolves to the brand teal token. Every interactive container with accent="filled" (the default) was rendering a brand-teal border at rest, where the intent is greyscale-200. Swap the rule to --goa-container-border, the existing neutral token already used by the base .content rule for non-filled accents. The interactive-border token is intentionally untouched in design-tokens because it remains the correct value for the accent="thick"/"thin" heading element, where teal-on-teal renders as a flush accent bar.
twjeffery
changed the title
twjeffery
force-pushed
the
tom/fix-container-interactive-content-border
branch
from
f99a7fd to
0c0313f
Compare
Collaborator
|
@twjeffery A small issue, your commit message says |
twjeffery
changed the title
Collaborator
Author
@ArakTaiRoth |
ArakTaiRoth
approved these changes
Apr 28, 2026
Collaborator
|
🎉 This PR is included in version 2.0.0-dev.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 2.0.0-dev.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 7.0.0-dev.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 5.0.0-dev.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #3848. That PR pointed the
.goa-container--interactive.accent--filled .contentrule at--goa-container-interactive-border, which resolves to brand teal. Every interactive container withaccent="filled"(the default) is rendering a teal border at rest. Intent is greyscale-200.Swaps the rule to
--goa-container-border, the existing neutral token already used by the base.contentrule for non-filled accents. One-line change. No token changes, no wrapper changes.Why not change the token
--goa-container-interactive-borderstays as is. It is still in legitimate use for the heading element onaccent="thick"andaccent="thin", where teal-on-teal renders as the flush accent bar. Recoloring the token would put a gray outline around that bar.Test plan
accent="filled"interactive container: greyscale-200 border at rest.accent="thick"andaccent="thin": flush teal accent bar at top, no outline around it.