fix(#3762): AppHeader Slots#3909
Open
willcodeforcoffee wants to merge 1 commit into
Open
Conversation
willcodeforcoffee
force-pushed
the
eric/bug3762-AppHeader-slots
branch
from
681a117 to
c525784
Compare
|
Preview links
Built from commit 8685814. Previews are removed automatically when this PR closes. |
willcodeforcoffee
force-pushed
the
eric/bug3762-AppHeader-slots
branch
from
524280a to
8685814
Compare
willcodeforcoffee
added
Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
Our AppHeader examples are using a
slotproperty on some of our components, design.alberta.ca/components/app-header#tab-1, specifically, the Header with Navigation example.See:
After (the change)
Several changes have been made to make these controls more consistent with other controls.
banner,phase,navigation, andutilitiesslots.banner,phase,navigation, andutilitiesslots.headertoapp-headerandheader-menutoapp-header-menuBackward compatibility with slots is maintained.
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test