Skip to content

fix(#3892): stop popover from closing parent popover, drawer, or modal#3913

Open
bdfranck wants to merge 2 commits into
devfrom
benji/3892-popover-closing-fix
Open

fix(#3892): stop popover from closing parent popover, drawer, or modal#3913
bdfranck wants to merge 2 commits into
devfrom
benji/3892-popover-closing-fix

Conversation

@bdfranck
Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck commented May 5, 2026

This PR stops a child popover from closing a parent popover, drawer, or modal with the following tweaks:

  1. Stop the Dropdown "_close" event listener from bubbling the event
  2. When a popover checks to close other popovers, it ignores a popover that is a parent

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://GovAlta.github.io/ui-components/pr-preview-angular/pr-3913/

Built to branch gh-pages at 2026-05-08 16:13 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Preview links

Target URL
Docs https://govalta.github.io/ui-components/pr-preview/pr-3913/
React playground https://govalta.github.io/ui-components/pr-preview-react/pr-3913/
Angular playground https://govalta.github.io/ui-components/pr-preview-angular/pr-3913/

Built from commit b1fff72. Previews are removed automatically when this PR closes.

This comment was marked as outdated.

@bdfranck bdfranck linked an issue May 6, 2026 that may be closed by this pull request
@bdfranck bdfranck force-pushed the benji/3892-popover-closing-fix branch 2 times, most recently from 2e3c5c7 to 30b7606 Compare May 7, 2026 21:05
@bdfranck bdfranck force-pushed the benji/3892-popover-closing-fix branch from 30b7606 to 80c4c95 Compare May 7, 2026 21:06
@bdfranck bdfranck changed the title Benji/3892 popover closing fix fix(#3892): stop popover from closing parent popover, drawer, or modal May 7, 2026
@bdfranck bdfranck marked this pull request as ready for review May 7, 2026 21:12
Comment thread apps/prs/angular/src/routes/bugs/3892/bug3892.component.html
@bdfranck bdfranck requested a review from ArakTaiRoth May 8, 2026 16:20
Copy link
Copy Markdown
Collaborator

@willcodeforcoffee willcodeforcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Popover closing after selecting a date in a Date Picker

4 participants