Skip to content

ci: remove gitleaks secret-scan job (ADR-001)#35

Closed
Shaivpidadi wants to merge 1 commit intomainfrom
fix/gov-1865-remove-gitleaks-secret-scan
Closed

ci: remove gitleaks secret-scan job (ADR-001)#35
Shaivpidadi wants to merge 1 commit intomainfrom
fix/gov-1865-remove-gitleaks-secret-scan

Conversation

@Shaivpidadi
Copy link
Copy Markdown
Member

Summary

  • Remove the secret-scan job from .github/workflows/ci.yml that ran gitleaks/gitleaks-action@v2.
  • ADR-001 mandates GitHub-native secret scanning only — never gitleaks or alternatives.
  • GitHub-native secret scanning is already enabled at the repo level and covers this surface.
  • No other CI jobs or triggers are touched. No branch-protection changes (reconciled in GOV-1854).

GovernsAI Tracker issue

GOV-1865

Reviewers

Tagging Nexus (code quality) and Cipher (security/arch) — both approvals required.

Test plan

  • lint, typecheck, test jobs continue to run on PR/push to main.
  • No gitleaks references remain in .github/workflows/*.yml.
  • PR passes remaining required checks.

ADR-001 mandates GitHub-native secret scanning only — never gitleaks
or alternatives. GitHub native secret scanning remains enabled at the
repo level and covers this surface.

Refs: GOV-1865
@Shaivpidadi
Copy link
Copy Markdown
Member Author

Closing as obsolete: dev branch no longer contains a gitleaks/secret-scan job (verified via grep on origin/dev:.github/workflows/ci.yml). ADR-001 is already satisfied. The branch was based on a much older snapshot of dev, making the diff effectively a regression rather than a targeted removal. Reopening would require rebuilding from current dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant