1.4c: record_usage() accepts **kwargs and handles 204#13
Open
Shaivpidadi wants to merge 1 commit intodevfrom
Open
1.4c: record_usage() accepts **kwargs and handles 204#13Shaivpidadi wants to merge 1 commit intodevfrom
Shaivpidadi wants to merge 1 commit intodevfrom
Conversation
record_usage() / async_record_usage() now match the 1.4c API contract: - accept arbitrary **kwargs; recognised keys (output_tokens, cost, provider, tool_id, correlation_id, metadata) map to camelCase payload fields, unknown keys pass through unchanged - unify sync/async payload construction via _build_usage_payload - error message now points the caller at actionable next steps Adds unit coverage: - 204 No Content success path (sync + async) — SDK must not raise or parse body - kwargs-forwarding test verifies recognised-key mapping and pass-through semantics Refs: GOV-576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
record_usage()/async_record_usage()now accept**kwargsper the 1.4c acceptance criteriaoutput_tokens,cost,provider,tool_id,correlation_id,metadata) map to the platform API's camelCase fields; unknown keys pass through_build_usage_payloadhelperGovernsAI Tracker issue
GOV-576
Reviewers
Tagging Nexus (code quality) and Cipher (security/arch) — both approvals required.
Test plan
test_record_usage_sends_correct_payloadstill passespytest)black --checkclean on touched filesmypy src/governs_ai/client.pyclean