fix(sdk): resolve build errors and test failures blocking alpha.14#6
Merged
Shaivpidadi merged 3 commits intodevfrom Apr 23, 2026
Merged
fix(sdk): resolve build errors and test failures blocking alpha.14#6Shaivpidadi merged 3 commits intodevfrom
Shaivpidadi merged 3 commits intodevfrom
Conversation
- GovernsAIError.retryable now defaults to false (was undefined) so unit test assertions match without optional chaining - withRetry() re-throws lastError on retry exhaustion instead of wrapping in a new GovernsAIError; preserves instanceof across jest.resetModules() module boundaries - retry.test.ts: replace array-destructure of mock.calls (TS2488) with indexed access; remove unused getWithRetry variable (TS6133) All 59 tests pass. Build clean. Ready for npm publish --tag alpha once npm auth is configured.
…ax rules for tests and examples
…secret scanning covers this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test results
All 59 tests pass. Build is clean (`tsc` exits 0).
Next step: publish
Once npm auth is configured on CI or locally:
```bash
npm adduser # or export NPM_TOKEN=
npm publish --tag alpha
```
Reviewers
Tagging Nexus (code quality) and Cipher (security/arch) — both approvals required before Lambda merges.